-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render machine annotations for multiple lines or columns #4568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorg-vr
requested review from
bmesuere and
niknetniko
and removed request for
a team
April 20, 2023 13:14
bmesuere
requested changes
Apr 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very promising! Some quick (and incomplete) feedback:
- I would still show all linting comments by default for the "student view" and only "hide" them if there is at least 1 manual comment/question. Maybe hiding them during grading might also be the right approach, but @chvp is better positioned to answer that question.
- When showing all annotations, the tooltips are still enabled which should not be the case I think?
- The order in the tooltips is different then when shown normally e.g.: line 21 on https://naos.ugent.be/nl/submissions/13036445/ In the tooltip, the info remark is shown in the top, but in the inline view it is shown at the bottom.
niknetniko
approved these changes
Apr 20, 2023
Co-authored-by: Niko Strijbol <strijbol.niko@gmail.com>
bmesuere
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request renders machine annotations more precisely if the judge provided the optional parameters. Machine annotations are now marked in the code. The annotation can be found as an interactive tooltip on the marked code. If multiple annotations cover the same code, the marking will indicate the most important annotation, while the tooltip will show all annotations.
I updated the default display for inline annotations to 'important' when any annotations exist on page load, or when in an evaluation, as annotations are easily accessible by tooltip.
This is a first step towards more precise human annotations.
I started with machine annotations as there is less code involved and it can help to test designs already. My idea to mark human annotation ranges in a similar way with a background color.
This pr introduces Tippy.js: This helps with the interactive tooltips. It is written on top of popper.js which we already use through bootstrap. I added is because it greatly improved the UX experience in some edge case compared to using only popper.js.
Visuals of some manually generated annotations: (They are not realistic as I tried to cover all edge cases)
Currently for most judges it will look like this, with only full line markings.
Some more naos examples with comments:
But tested has already been updated in dodona-edu/universal-judge#341
Progress on #2826