Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent crash on series creation without course #4848

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Prevent crash on series creation without course #4848

merged 3 commits into from
Aug 1, 2023

Conversation

bmesuere
Copy link
Member

Reverts #4617 because of the comment in #4617 (comment)

@bmesuere bmesuere requested a review from a team as a code owner July 28, 2023 09:27
@bmesuere bmesuere requested review from jorg-vr and chvp and removed request for a team July 28, 2023 09:27
@jorg-vr jorg-vr marked this pull request as draft July 28, 2023 09:27
@freyavs
Copy link
Contributor

freyavs commented Jul 29, 2023 •
edited
Loading

just for info and checking if this is okay: by authorizing on series the error is now 422 "course": ["must exist"] (when no "course_id" is given)

@freyavs freyavs requested review from niknetniko and removed request for chvp July 29, 2023 14:08
@freyavs freyavs marked this pull request as ready for review July 31, 2023 06:25
@jorg-vr
Copy link
Contributor

jorg-vr commented Jul 31, 2023

You could maybe leave the test (Without the text check)

niknetniko
niknetniko requested changes Jul 31, 2023
View reviewed changes
app/controllers/series_controller.rb Outdated Show resolved Hide resolved
@bmesuere bmesuere added the bug Something isn't working label Aug 1, 2023
@jorg-vr jorg-vr requested a review from niknetniko August 1, 2023 07:17
@jorg-vr jorg-vr merged commit cd26776 into main Aug 1, 2023
@jorg-vr jorg-vr deleted the revert-4617-fix/series-without-courseid branch August 1, 2023 09:07
@jorg-vr jorg-vr temporarily deployed to naos August 1, 2023 09:07 — with GitHub Actions Inactive
@jorg-vr jorg-vr temporarily deployed to production August 1, 2023 09:11 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorg-vr jorg-vr jorg-vr approved these changes

@niknetniko niknetniko niknetniko approved these changes

Assignees

@freyavs freyavs

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bmesuere @freyavs @jorg-vr @niknetniko