util.js: remove jquery and convert to typescript #4849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freyavs
requested review from
bmesuere and
niknetniko
and removed request for
a team
bmesuere
reviewed
Aug 2, 2023
bmesuere
approved these changes
Aug 4, 2023
jorg-vr
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts util.js to typescript and removes jquery (also removes jquery from copy.ts).
There are also slight changes/fixes in the tooltip for the clipboard copying used in copy.ts. It works the same as before the changes (with a slightly longer time because it was disappearing very quickly), though I think it can be improved/looked at a bit more (but maybe not in this PR).
Also util.ts is now renamed to utilities.ts because it was confusing imports of "util" with another module of the same name (so renamed to avoid generic names).
This is progress on #3590