Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rails views: start removing jQuery #4851

Merged
merged 13 commits into from
Aug 8, 2023
Merged

Conversation

freyavs
Copy link
Contributor

@freyavs freyavs commented Jul 31, 2023

This pull request removes jQuery in the rails views where html is being set for activities, courses, users, ... (there's still some views left with .html being used)

This is progress on #3590

@freyavs freyavs added the chore Repository/build/dependency maintenance label Jul 31, 2023
@freyavs freyavs self-assigned this Jul 31, 2023
@freyavs freyavs marked this pull request as ready for review August 4, 2023 06:35
@freyavs freyavs requested a review from a team as a code owner August 4, 2023 06:35
@freyavs freyavs requested review from jorg-vr and chvp and removed request for a team August 4, 2023 06:35
@freyavs freyavs marked this pull request as draft August 5, 2023 09:36
@freyavs freyavs changed the title activities: remove jQuery in rails views rails views: start removing jQuery Aug 5, 2023
@freyavs
Copy link
Contributor Author

freyavs commented Aug 6, 2023

Added more to this PR because I was finishing my last hours and needed the function added here

@freyavs freyavs marked this pull request as ready for review August 6, 2023 17:12
@jorg-vr jorg-vr requested a review from bmesuere August 7, 2023 13:28
app/assets/javascripts/utilities.ts Outdated Show resolved Hide resolved
app/assets/javascripts/utilities.ts Outdated Show resolved Hide resolved
Co-authored-by: Charlotte Van Petegem <charlotte.vanpetegem@ugent.be>
@jorg-vr jorg-vr merged commit ccb7679 into main Aug 8, 2023
@jorg-vr jorg-vr deleted the chore/views-activities-jquery-removal branch August 8, 2023 08:04
@jorg-vr jorg-vr temporarily deployed to naos August 8, 2023 08:04 — with GitHub Actions Inactive
@jorg-vr jorg-vr temporarily deployed to production August 8, 2023 08:09 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Repository/build/dependency maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants