-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rails views: start removing jQuery #4851
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmesuere
reviewed
Aug 4, 2023
jorg-vr
reviewed
Aug 4, 2023
freyavs
changed the title
activities: remove jQuery in rails views
rails views: start removing jQuery
Aug 5, 2023
Added more to this PR because I was finishing my last hours and needed the function added here |
jorg-vr
approved these changes
Aug 7, 2023
chvp
approved these changes
Aug 7, 2023
Co-authored-by: Charlotte Van Petegem <charlotte.vanpetegem@ugent.be>
bmesuere
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes jQuery in the rails views where html is being set for activities, courses, users, ... (there's still some views left with .html being used)
This is progress on #3590