-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create separate show and edit page for saved-annotations #4885
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- On the show page, the annotation data is listed as key value pairs which is a bit plain. Can't we make it a sentence? This annotation was use x times in the Visualisation Test course for the Curling exercise. The annotation itself could be formatted as a quote or callout or something like that.
- The table title is "linked annotations", shouldn't that be linked submissions?
-
Maybe open the linked submissions in a new tab? - On the save annotation index (not edited here) in the first column, the "1 keer gebruikt" text is wrapped in
p
tags which adds unnecessary bottom margin. This can probably be a div. (resolved in Make saved annotations filterable and sortable #4887)
Co-authored-by: Niko Strijbol <strijbol.niko@gmail.com>
I am not a fan of this. It is not good practice to auto open different tabs for links that stay within your website. I often end up with multiple unused Dodona tabs because the course list also opens courses in a new tab. I do not like that behavior. If a user wants the link to open in a new tab, most browsers support this with a right click option or a keyboard shortcut |
Co-authored-by: Bart Mesuere <Bart.Mesuere@UGent.be>
This pull request adds a separate show and edit page for saved annotations.
This page is now linked from an annotation and from the list page.
Show:
This page also shows a list of usages. This a generic submission listing.
I will replace this by a more dedicated annotation listing in the future.
Edit:
Updated list view: (Title is now a link and edit button is removed)
Updated annotation view: (Link icon is replaced by comment bookmark icon and is now an actionable link color and directs to show page)
Part of #4564