Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create separate show and edit page for saved-annotations #4885

Merged
merged 22 commits into from
Aug 16, 2023

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Aug 10, 2023

This pull request adds a separate show and edit page for saved annotations.
This page is now linked from an annotation and from the list page.

Show:
image
This page also shows a list of usages. This a generic submission listing.
I will replace this by a more dedicated annotation listing in the future.

Edit:
image

Updated list view: (Title is now a link and edit button is removed)
image
Updated annotation view: (Link icon is replaced by comment bookmark icon and is now an actionable link color and directs to show page)
image

Part of #4564

@jorg-vr jorg-vr added the enhancement A change that isn't substantial enough to be called a feature label Aug 10, 2023
@jorg-vr jorg-vr self-assigned this Aug 10, 2023
@jorg-vr jorg-vr marked this pull request as ready for review August 11, 2023 12:30
@jorg-vr jorg-vr requested a review from a team as a code owner August 11, 2023 12:30
@jorg-vr jorg-vr requested review from bmesuere and niknetniko and removed request for a team August 11, 2023 12:30
@bmesuere bmesuere temporarily deployed to mestra August 14, 2023 12:23 — with GitHub Actions Inactive
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • On the show page, the annotation data is listed as key value pairs which is a bit plain. Can't we make it a sentence? This annotation was use x times in the Visualisation Test course for the Curling exercise. The annotation itself could be formatted as a quote or callout or something like that.
  • The table title is "linked annotations", shouldn't that be linked submissions?
  • Maybe open the linked submissions in a new tab?
  • On the save annotation index (not edited here) in the first column, the "1 keer gebruikt" text is wrapped in p tags which adds unnecessary bottom margin. This can probably be a div. (resolved in Make saved annotations filterable and sortable #4887)

app/views/saved_annotations/edit.html.erb Outdated Show resolved Hide resolved
app/views/saved_annotations/edit.html.erb Outdated Show resolved Hide resolved
app/views/saved_annotations/edit.html.erb Outdated Show resolved Hide resolved
app/views/saved_annotations/edit.html.erb Outdated Show resolved Hide resolved
@jorg-vr
Copy link
Contributor Author

jorg-vr commented Aug 16, 2023

Maybe open the linked submissions in a new tab?

I am not a fan of this. It is not good practice to auto open different tabs for links that stay within your website. I often end up with multiple unused Dodona tabs because the course list also opens courses in a new tab. I do not like that behavior.

If a user wants the link to open in a new tab, most browsers support this with a right click option or a keyboard shortcut

@jorg-vr jorg-vr requested review from bmesuere and niknetniko August 16, 2023 12:09
@bmesuere bmesuere added the deploy mestra Request a deployment on mestra label Aug 16, 2023
@bmesuere bmesuere temporarily deployed to mestra August 16, 2023 12:17 — with GitHub Actions Inactive
@github-actions github-actions bot removed the deploy mestra Request a deployment on mestra label Aug 16, 2023
config/locales/views/saved_annotations/nl.yml Outdated Show resolved Hide resolved
config/locales/views/saved_annotations/nl.yml Outdated Show resolved Hide resolved
app/views/saved_annotations/show.html.erb Outdated Show resolved Hide resolved
jorg-vr and others added 2 commits August 16, 2023 14:32
Co-authored-by: Bart Mesuere <Bart.Mesuere@UGent.be>
@jorg-vr jorg-vr merged commit 7dc49cb into main Aug 16, 2023
@jorg-vr jorg-vr deleted the enhance/saved-annotation-page branch August 16, 2023 13:20
@jorg-vr jorg-vr temporarily deployed to naos August 16, 2023 13:21 — with GitHub Actions Inactive
@jorg-vr jorg-vr temporarily deployed to production August 16, 2023 13:25 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A change that isn't substantial enough to be called a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants