Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only return administrating courses in LTI picker #5124

Merged
merged 5 commits into from
Nov 9, 2023
Merged

Only return administrating courses in LTI picker #5124

merged 5 commits into from
Nov 9, 2023

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Nov 9, 2023 •
edited
Loading

This pull request limits the courses returned by the LTI picker to administrating courses.

A user should thus easily find al relevant courses.

  • tested on uforatest with naos

@jorg-vr jorg-vr added the bug Something isn't working label Nov 9, 2023
@jorg-vr jorg-vr self-assigned this Nov 9, 2023
@jorg-vr jorg-vr added the deploy naos Request a deployment on naos label Nov 9, 2023
@github-actions github-actions bot removed the deploy naos Request a deployment on naos label Nov 9, 2023
@jorg-vr jorg-vr changed the title Only return admistarting courses in LTI picker Only return administrating courses in LTI picker Nov 9, 2023
@jorg-vr jorg-vr added the deploy naos Request a deployment on naos label Nov 9, 2023
@github-actions github-actions bot removed the deploy naos Request a deployment on naos label Nov 9, 2023
@jorg-vr jorg-vr marked this pull request as ready for review November 9, 2023 13:25
@jorg-vr jorg-vr requested a review from a team as a code owner November 9, 2023 13:25
@jorg-vr jorg-vr requested review from bmesuere and niknetniko and removed request for a team November 9, 2023 13:25
bmesuere
bmesuere approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this always been a bug?

@jorg-vr
Copy link
Contributor Author

jorg-vr commented Nov 9, 2023

Has this always been a bug?
There was a 'policy scope', that would at leas limit it to accessible courses in theory. But I have not thoroughly tested this.
But there was never any code to limit it to administrating courses

@jorg-vr jorg-vr merged commit fcc0d3c into main Nov 9, 2023
13 of 15 checks passed
@jorg-vr jorg-vr deleted the fix/ufora-js branch November 9, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niknetniko niknetniko niknetniko approved these changes

@bmesuere bmesuere bmesuere approved these changes

Assignees

@jorg-vr jorg-vr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorg-vr @bmesuere @niknetniko