Make ctrl-f more usable on submissions #5158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorg-vr
requested review from
bmesuere and
chvp
and removed request for
a team
bmesuere
approved these changes
Nov 15, 2023
chvp
approved these changes
Nov 15, 2023
|
I think this was part of the reason
I am also not 100% wordbreaks will always be made the same way by browsers. I couldn't find a good definition for what soft-wrap points are considered by the browser. (But couldn't reproduce a breaking case in practice) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves browser search (ctrl-f) features on submission pages.
The issue was that search matched each code element three times as it is repeated in each layer.
This issue was reported by Steven, who made the case for the search feature when trying to understand a students code while grading.
A side effect: copying code will only copy spaces while our custom hack isn't working. This will happen more often with #5157 so accepting this pr will require changes there.
I do not see any other options for fixing this aside of reverting the whole three layered approach for annotations.
But I am open for suggestions.