Fix line of code not shown on invalid judge output #5205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorg-vr
requested review from
bmesuere and
niknetniko
and removed request for
a team
niknetniko
approved these changes
Nov 28, 2023
|
This solution is literally: the whole shebang |
bmesuere
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a line of code not being shown when the judge returns out of bounds column indexes.
Eg of submission with the issue: https://dodona.be/nl/submissions/16080236/#code
Here the second line is hidden.
The issue is not reproducible as the judge has already been fixed, but from the error message I discovered the issue.
Although this was caused by the judge returning to many columns, we should deal with such case more gracefully. With the new fix, a column number out of bounds will be treated as marking the whole line.