Require at least one correct submission and a valid config before publishing #5330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorg-vr
added
the
enhancement
jorg-vr
requested review from
bmesuere and
chvp
and removed request for
a team
chvp
requested changes
Jan 30, 2024
chvp
approved these changes
Jan 30, 2024
bmesuere
requested changes
Jan 30, 2024
There was a problem hiding this comment.
In the current implementation, the check is only done when trying to publish. I would do this every time when we render the "this exercise is a draft" callout and add some kind of checklist there so it is clear which steps need to be taken, like
- have a problem description in Dutch and/or English
- have a valid configuration
- have at least one correct submission
In the future, we could expand that list if we would think of other requirements.
jorg-vr
changed the title
bmesuere
requested changes
Feb 1, 2024
Co-authored-by: Bart Mesuere <Bart.Mesuere@UGent.be>
Co-authored-by: Bart Mesuere <Bart.Mesuere@UGent.be>
bmesuere
approved these changes
Feb 1, 2024
chvp
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a validation to activities that checks if an activity has at least one correct submission and a valid config before publishing.
This info is displayed to the user in the notice.
Closes #5084