Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplicate series icon when favoring a course #5358

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Avoid duplicate series icon when favoring a course #5358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions app/assets/javascripts/favorite_course_buttons.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { Toast } from "./toast";
import { fetch, getParentByClassName } from "utilities";
import { i18n } from "i18n/i18n";
import { SeriesIcon } from "components/series_icon";

function initFavoriteButtons(doc: Document | HTMLElement = document): void {
function init(): void {
Expand Down Expand Up @@ -44,6 +45,11 @@
cloneFavButton.setAttribute("title", i18n.t("js.unfavorite-course-do"));
new bootstrap.Tooltip(cloneFavButton); // is enabled by default
cloneFavButton.addEventListener("click", toggleFavorite);
// hack to fix double rendering of content of lit element 'd-series-icon'
clone.querySelectorAll("d-series-icon").forEach((el: SeriesIcon) => {
el.replaceChildren();
el.requestUpdate();

Check warning on line 51 in app/assets/javascripts/favorite_course_buttons.ts

View check run for this annotation

Codecov / codecov/patch

app/assets/javascripts/favorite_course_buttons.ts#L49-L51 

Added lines #L49 - L51 were not covered by tests
});
} else {
new Toast(i18n.t("js.favorite-course-failed"));
}
Expand Down