-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add types for typescript #573
Open
BrentBlanckaert
wants to merge
8
commits into
master
Choose a base branch
from
feat/add-types-typescript
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
cb71451
add function to generate types
BrentBlanckaert b3f2e3c
Added types for TypeScript
BrentBlanckaert a791d6a
fixed linting and types
BrentBlanckaert 387f42f
fixed some of the tests
BrentBlanckaert 2e62ce3
removed some redundant checks
BrentBlanckaert e51e490
Adding extra test
BrentBlanckaert 0982edc
fixed linting
BrentBlanckaert d51c11e
updated tests for the second time
BrentBlanckaert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,12 +3,15 @@ | |
from tested.datatypes import ( | ||
AdvancedNothingTypes, | ||
AdvancedNumericTypes, | ||
AdvancedStringTypes, | ||
AllTypes, | ||
BasicBooleanTypes, | ||
BasicNothingTypes, | ||
BasicNumericTypes, | ||
BasicObjectTypes, | ||
BasicSequenceTypes, | ||
BasicStringTypes, | ||
resolve_to_basic, | ||
) | ||
from tested.datatypes.advanced import AdvancedObjectTypes | ||
from tested.languages.conventionalize import submission_file | ||
|
@@ -33,6 +36,7 @@ | |
StringType, | ||
Value, | ||
VariableAssignment, | ||
VariableType, | ||
as_basic_type, | ||
) | ||
from tested.testsuite import MainInput | ||
|
@@ -129,6 +133,74 @@ | |
return result | ||
|
||
|
||
def convert_declaration(statement: Statement, tp: AllTypes | VariableType) -> str: | ||
if isinstance(tp, VariableType): | ||
return f"{tp.data}" | ||
elif tp == AdvancedNothingTypes.UNDEFINED: | ||
return "undefined" | ||
|
||
basic = resolve_to_basic(tp) | ||
if basic == BasicBooleanTypes.BOOLEAN: | ||
return "boolean" | ||
elif basic == BasicStringTypes.TEXT: | ||
return "string" | ||
elif basic == BasicNumericTypes.INTEGER: | ||
return "number" | ||
elif basic == BasicNumericTypes.REAL: | ||
return "number" | ||
elif basic == BasicNothingTypes.NOTHING: | ||
return "null" | ||
elif basic == BasicObjectTypes.MAP: | ||
return "object" | ||
elif basic == BasicSequenceTypes.SEQUENCE: | ||
type_ = "Object" | ||
|
||
if isinstance(statement, VariableAssignment): | ||
expression = statement.expression | ||
else: | ||
expression = statement | ||
if isinstance(expression, SequenceType): | ||
type_ = { | ||
( | ||
convert_declaration(element, element.type) | ||
if not isinstance(element, Identifier) | ||
and not isinstance(element, FunctionCall) | ||
else "id" | ||
) | ||
for element in expression.data | ||
} | ||
if "id" in type_: | ||
type_ = "any" | ||
else: | ||
type_ = "|".join(type_) | ||
|
||
return f"Array<{type_}>" | ||
elif basic == BasicSequenceTypes.SET: | ||
type_ = "Object" | ||
|
||
if isinstance(statement, VariableAssignment): | ||
expression = statement.expression | ||
else: | ||
expression = statement | ||
if isinstance(expression, SequenceType): | ||
type_ = { | ||
( | ||
convert_declaration(element, element.type) | ||
if not isinstance(element, Identifier) | ||
and not isinstance(element, FunctionCall) | ||
else "id" | ||
) | ||
for element in expression.data | ||
} | ||
if "id" in type_: | ||
type_ = "any" | ||
else: | ||
type_ = "|".join(type_) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same comment as above |
||
|
||
return f"Set<{type_}>" | ||
raise AssertionError(f"Unknown type: {tp!r}") | ||
|
||
|
||
def convert_statement(statement: Statement, internal=False, full=False) -> str: | ||
if isinstance(statement, Identifier): | ||
return statement | ||
|
@@ -143,11 +215,13 @@ | |
) | ||
elif isinstance(statement, VariableAssignment): | ||
if full: | ||
prefix = "let " | ||
else: | ||
prefix = "" | ||
return ( | ||
f"let {statement.variable} : {convert_declaration(statement, statement.type)} = " | ||
f"{convert_statement(statement.expression, True)}" | ||
) | ||
|
||
return ( | ||
f"{prefix}{statement.variable} = " | ||
f"{statement.variable} = " | ||
f"{convert_statement(statement.expression, True)}" | ||
) | ||
raise AssertionError(f"Unknown statement: {statement!r}") | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you filter distinct types before doing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type_
is a set there. So that should be fine.