Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CLDR plugin and loader #371

Merged
merged 4 commits into from
Feb 11, 2020
Merged

Use CLDR plugin and loader #371

merged 4 commits into from
Feb 11, 2020

Conversation

agubler
Copy link
Member

@agubler agubler commented Jan 27, 2020

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR
  • schema.json has been updated appropriately

Description:

Include the CLDR loader and plugin for i18n enabled applications. Add cldr-elide static has flag to elide CLDR modules from i18n itself.

Related to dojo/framework#655

Note: requires release of dojo/webpack-contrib

@agubler agubler requested a review from mwistrand January 27, 2020 14:37
@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #371 into master will decrease coverage by 0.2%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #371      +/-   ##
==========================================
- Coverage   48.86%   48.65%   -0.21%     
==========================================
  Files          10       10              
  Lines         702      705       +3     
  Branches      201      204       +3     
==========================================
  Hits          343      343              
- Misses        359      362       +3
Impacted Files Coverage Δ
src/base.config.ts 19.4% <14.28%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e977d8...5647956. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants