Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tsx to list of linted file extensions #374

Merged
merged 1 commit into from
Jan 31, 2020

Conversation

devpaul
Copy link
Member

@devpaul devpaul commented Jan 30, 2020

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR
  • schema.json has been updated appopriately

Description:

Updated the webpack config in base.config to include tsx as a file extension for the tslint-loader. Tested manually.

Resolves #351

image

@devpaul devpaul requested a review from agubler January 30, 2020 22:45
@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #374 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #374   +/-   ##
=======================================
  Coverage   48.92%   48.92%           
=======================================
  Files          10       10           
  Lines         695      695           
  Branches      199      199           
=======================================
  Hits          340      340           
  Misses        355      355
Impacted Files Coverage Δ
src/base.config.ts 19.65% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86b6dfe...ed41011. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linting does not run on tsx files
2 participants