address review feedback

dojo · Jan 31, 2020 · f28b9b0 · f28b9b0
1 parent 8353859
commit f28b9b0
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/src/i18n/i18n.ts b/src/i18n/i18n.ts
@@ -219,9 +219,9 @@ export function setLocale(options: SetLocaleOptions = {}): Promise<string> | str
 	if (supplementalLoader && supplementalLoader !== true) {
 		loaderPromises.push(supplementalLoader());
 	}
-	const localCldrLoader = cldrLoaders[userLocale];
-	if (localCldrLoader && localCldrLoader !== true) {
-		loaderPromises.push(localCldrLoader());
+	const localeCldrLoader = cldrLoaders[userLocale];
+	if (localeCldrLoader && localeCldrLoader !== true) {
+		loaderPromises.push(localeCldrLoader());
 	}
 	const loadFallback = !matchedLocale && fallbackLoader && fallbackLoader !== true;
 	if (loadFallback && fallbackLoader && fallbackLoader !== true) {

diff --git a/tests/core/unit/middleware/i18n.tsx b/tests/core/unit/middleware/i18n.tsx
@@ -115,12 +115,12 @@ describe('i18n middleware', () => {
 			root.innerHTML,
 			'<div><div>{"foo":""}</div><div></div><div>true</div><div>{"locale":"es"}</div><button>es</button></div>'
 		);
-		es.resolver({ default: { foo: 'holla, {name}' } });
+		es.resolver({ default: { foo: 'hola, {name}' } });
 		await es.promise;
 		resolvers.resolveRAF();
 		assert.strictEqual(
 			root.innerHTML,
-			'<div><div>{"foo":"holla, {name}"}</div><div>holla, John</div><div>false</div><div>{"locale":"es"}</div><button>es</button></div>'
+			'<div><div>{"foo":"hola, {name}"}</div><div>hola, John</div><div>false</div><div>{"locale":"es"}</div><button>es</button></div>'
 		);
 	});
 

diff --git a/tests/core/unit/mixins/I18n.tsx b/tests/core/unit/mixins/I18n.tsx
@@ -124,12 +124,12 @@ describe('i18n Mixin', () => {
 			root.innerHTML,
 			'<div lang="es"><div>{"foo":""}</div><div></div><div>true</div><div>{"locale":"es"}</div><button>es</button></div>'
 		);
-		es.resolver({ default: { foo: 'holla, {name}' } });
+		es.resolver({ default: { foo: 'hola, {name}' } });
 		await es.promise;
 		resolvers.resolveRAF();
 		assert.strictEqual(
 			root.innerHTML,
-			'<div lang="es"><div>{"foo":"holla, {name}"}</div><div>holla, John</div><div>false</div><div>{"locale":"es"}</div><button>es</button></div>'
+			'<div lang="es"><div>{"foo":"hola, {name}"}</div><div>hola, John</div><div>false</div><div>{"locale":"es"}</div><button>es</button></div>'
 		);
 	});