This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
Description:
Proposal includes
ThemeableMixin
by default forWidgetBase
. Renames the originalWidgetBase.ts
toBase.ts
and adds a newWidgetBase.ts
module that importsBase
plus other named exports fromBase.ts
andThemeableMixin
and exportsThemableMixin(Base)
asWidgetBase
(and also re-exports all the other exports fromBase.ts
).This should be backwards compatible with existing usages of
WidgetBase
even if they haveThemeableMixin
applied.This requires #601 to fix the failing unit test.
Resolves #581