This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Do not own child widgets to ensure instances can be GC'd once they are no longer required #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomdye
reviewed
Nov 6, 2017
| @@ -363,7 +363,7 @@ export function filterAndDecorateChildren(children: undefined | DNode | DNode[], | |||
| } | |||
| children = Array.isArray(children) ? children : [ children ]; | |||
|
|
|||
| for (let i = 0; i < children.length;) { | |||
| for (let i = 0; i < children.length; ) { | |||
There was a problem hiding this comment.
nit picking, but why the extra space?
tomdye
approved these changes
Nov 6, 2017
kitsonk
approved these changes
Nov 6, 2017
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
Description:
As per the investigation in #745, when a parent owns its widget children it creates a handle reference that is never severed and therefore the widgets are never available for garbage collection.
Removing the automatic
ownon child widgets enables children to be GC'd correctly once they are no longer in use.Related to #745