Skip to content

Commit

Permalink
Compile ensure-no_std in CI for new lambdaworks backend (lambdaclas…
Browse files Browse the repository at this point in the history
…s#1293)

* Ensure no-std for new lambdaworks backend

* Fix: use correct matrix var name in job

* Remove --release flag in ensure-no_std build

* Update lambdaworks to fix-no-std commit

* Update commit to main

* Bump lambdaworks-math version

* Update changelog
  • Loading branch information
MegaRedHand authored and kariy committed Jul 25, 2023
1 parent c959f6b commit 9f83498
Show file tree
Hide file tree
Showing 5 changed files with 63 additions and 68 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -163,14 +163,15 @@ jobs:
- name: Check no-std
run: |
cd ensure-no_std
cargo build --release
cargo build --no-default-features
cargo build
tests:
needs: build-programs
strategy:
fail-fast: false
matrix:
special-features: ["", "lambdaworks-felt"]
special_features: ["", "lambdaworks-felt"]
target: [ test, test-no_std, test-wasm ]
# TODO: features
name: Run tests
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

#### Upcoming Changes

* fix: bump *lambdaworks-math* to latest version, that fixes no-std support [#1293](https://github.com/lambdaclass/cairo-vm/pull/1293)

* build: remove dependecy to `thiserror` (use `thiserror-no-std/std` instead)

* chore: use LambdaWorks' implementation of bit operations for `Felt252` [#1291](https://github.com/lambdaclass/cairo-rs/pull/1291)
Expand Down
118 changes: 53 additions & 65 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions ensure-no_std/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ cairo-vm = { path = "../vm", default-features = false }

wee_alloc = "0.4.5"

[features]
default = ["lambdaworks-felt"]
lambdaworks-felt = ["cairo-felt/lambdaworks-felt"]


[profile.dev]
panic = "abort"
Expand Down
2 changes: 1 addition & 1 deletion felt/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ lazy_static = { version = "1.4.0", default-features = false, features = [
"spin_no_std",
] }
serde = { version = "1.0", features = ["derive"], default-features = false }
lambdaworks-math = { version = "0.1.1", default-features = false, optional = true }
lambdaworks-math = { version = "0.1.2", default-features = false, optional = true }

[dev-dependencies]
proptest = "1.1.0"
Expand Down

0 comments on commit 9f83498

Please sign in to comment.