Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for the app key of the data object in dokku_network_property #127

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

fr3fou
Copy link
Contributor

@fr3fou fr3fou commented Nov 11, 2021

This PR fixes the following bug from occuring

{
  "changed": false,
  "module_stderr": "Shared connection to [blank] closed.\r\n",
  "module_stdout": "{'global': True, 'property': 'initial-network', 'value': 'app-internal', 'app': None}\r\n\r\n{\"meta\": {\"present\": false, \"error\": \"When \\\"global\\\" is set to true, \\\"app\\\" must not be provided.\"}, \"failed\": true, \"msg\": \"When \\\"global\\\" is set to true, \\\"app\\\" must not be provided.\", \"invocation\": {\"module_args\": {\"global\": true, \"property\": \"initial-network\", \"value\": \"app-internal\", \"app\": null}}}\r\n",
  "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error",
  "rc": 1
}

When using the following task description:

- name: Setting a global network property
  dokku_network_property:
    global: true
    property: initial-network
    value: app-internal

Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @fr3fou !

I'll accept this without a test for the time being since the test would fail due to dokku/dokku#4915

@ltalirz ltalirz merged commit f5c8d1a into dokku:master Nov 11, 2021
@fr3fou fr3fou deleted the patch-1 branch November 12, 2021 07:31
@fr3fou fr3fou changed the title Fix the check for the app key of the data object in dokku_network_property fix: check for the app key of the data object in dokku_network_property Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants