Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dokku_builder library #129

Merged
merged 9 commits into from
Nov 18, 2021
Merged

feat: dokku_builder library #129

merged 9 commits into from
Nov 18, 2021

Conversation

fr3fou
Copy link
Contributor

@fr3fou fr3fou commented Nov 16, 2021

Closes #128

@fr3fou fr3fou marked this pull request as draft November 16, 2021 19:47
@fr3fou fr3fou marked this pull request as ready for review November 17, 2021 22:05
ltalirz
ltalirz requested changes Nov 17, 2021
View reviewed changes
Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot @fr3fou

I just spotted one small issue - otherwise good to merge

@fr3fou @ltalirz
fix: make app not required
c6aa3a2 
Co-authored-by: Leopold Talirz <leopold.talirz@gmail.com>
@ltalirz ltalirz merged commit 8f223a6 into dokku:master Nov 18, 2021
@fr3fou fr3fou changed the title feat: dokku_builder module feat: dokku_builder library Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ltalirz ltalirz ltalirz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dokku_builder: support changing the build directory
2 participants
@fr3fou @ltalirz