Support of JsonPolymorphic and JsonDerivedType attributes #3170
+2,341
−3,291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix integration Basic and NSwagClientExample tests to have different outputs for .net6
src/Swashbuckle.AspNetCore.Annotations/AnnotationsSwaggerGenOptionsExtensions.cs
Outdated
Show resolved
Hide resolved
src/Swashbuckle.AspNetCore.Annotations/AnnotationsSwaggerGenOptionsExtensions.cs
Outdated
Show resolved
Hide resolved
test/Swashbuckle.AspNetCore.IntegrationTests/SwaggerVerifyIntegrationTest.cs
Show resolved
Hide resolved
test/WebSites/NswagClientExample/Controllers/SystemTextJsonAnimalsController.cs
Show resolved
Hide resolved
Co-authored-by: Martin Costello <martin@martincostello.com>
fix `SwaggerEndpoint_ReturnsValidSwaggerJson_DotNet6` test - it wasn't using parameters
martincostello
approved these changes
Nov 24, 2024
|
Before I merge this, could you copy-over the changes to the README about how this works please? |
|
added Readme |
|
Resolves #2571. |
|
Yeah, this is actually nice! Thanks guys! |
|
Thanks for picking up my PR and finishing the work. Good job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue or feature being addressed
supersedes #2671
Details on the issue fix or feature implementation
Added checks for
System.Text.Jsonpolymorphic attributes in the same handlers, where swagger native attributes are handled. Swagger attributes have priority overSystem.Text.Jsonones.Added this case to
NSwagClientExampleintegration testRefactored the way
BasicandNSwagClientExampletests run. They both have different outputs for .net6 and .net8/9. I made a different theory for such tests in .net6 mode. The redudantSwaggerEndpoint_ReturnsValidSwaggerJson_Basic_DotNet_8was deleted, as it is handled by the mainSwaggerEndpoint_ReturnsValidSwaggerJson