Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow no match to be found to avoid throwing an exception #3188

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

moni-dips
Copy link
Contributor

Pull Request

The issue or feature being addressed

This change fixes #3187

Details on the issue fix or feature implementation

The if indicates this was the intended method call to use.

@martincostello
Copy link
Collaborator

Thanks for the PR - could you update our tests to catch this issue so it doesn't regress in the future please.

@moni-dips
Copy link
Contributor Author

I can do that, yes, but it will be some time before I can start looking at it.

@moni-dips
Copy link
Contributor Author

Thanks for the PR - could you update our tests to catch this issue so it doesn't regress in the future please.

Test has been added

@martincostello martincostello added this to the v7.2.0 milestone Dec 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.65%. Comparing base (3832d77) to head (a896da4).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3188   +/-   ##
=======================================
  Coverage   83.65%   83.65%           
=======================================
  Files          76       76           
  Lines        3175     3175           
  Branches      536      536           
=======================================
  Hits         2656     2656           
  Misses        519      519           
Flag Coverage Δ
Linux 83.65% <100.00%> (ø)
Windows 83.65% <100.00%> (ø)
macOS 83.65% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello enabled auto-merge (squash) December 9, 2024 10:56
@martincostello
Copy link
Collaborator

Thanks for adding the test.

@martincostello martincostello merged commit fc77e5a into domaindrivendev:master Dec 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Sequence contains no matching element when accessing swagger.json
3 participants