Better support for Django 3.2.* #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mport name 'ugettext_lazy' from 'django.utils.translation'"
…ault configuration.
…angoproject.com/en/4.0/releases/3.2/#customizing-type-of-auto-created-primary-keys This prevents the app from requiring further migrations be generated post-install in deployment scenarios where the project including this app has specified a DEFAULT_AUTO_FIELD other than 'django.db.models.AutoField'
…t.com/en/4.0/releases/3.2/#customizing-type-of-auto-created-primary-keys to suppress warnings during test running.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
The main purpose is to define the default_auto_field explicitly, in line with the 3.2 release notes here https://docs.djangoproject.com/en/4.0/releases/3.2/#customizing-type-of-auto-created-primary-keys
This prevents an extra migration being required in the event that this app is included in a project which defines a default_auto_field of anything other than 'django.db.models.AutoField'
Perhaps BigAutoField is a better choice here, in which case this app would need to be shipped with the supporting migration - I shall leave that up to the authors, but this should work as is, without changing any existing deployments.
Other changes are limited to strictly those required to support the unit tests passing locally, specifically:
ugettext_lazyhaving apparently moved in 4.X and hence a failing importruntests.pytests/apps.pyfor explicitly setting default_auto_field to suppress warnings during test running