From c7ec67d0eb074543ece1cfeaedfc0531a9eb32cf Mon Sep 17 00:00:00 2001 From: Stephen Worley Date: Tue, 22 Nov 2022 16:41:54 -0500 Subject: [PATCH] zebra: ignore zero_mac without VNI deletes Ignore zebra_mac updates if they do not contain a VNI for vxlan interface. We don't have anything we can do with them. ''' ==443593== Process terminating with default action of signal 6 (SIGABRT): dumping core ==443593== at 0x4E1156C: __pthread_kill_implementation (in /usr/lib64/libc.so.6) ==443593== by 0x4DC4D15: raise (in /usr/lib64/libc.so.6) ==443593== by 0x49823C7: core_handler (sigevent.c:261) ==443593== by 0x4DC4DBF: ??? (in /usr/lib64/libc.so.6) ==443593== by 0x4E1156B: __pthread_kill_implementation (in /usr/lib64/libc.so.6) ==443593== by 0x4DC4D15: raise (in /usr/lib64/libc.so.6) ==443593== by 0x4D987F2: abort (in /usr/lib64/libc.so.6) ==443593== by 0x49C3064: _zlog_assert_failed (zlog.c:700) ==443593== by 0x4F5E6D: zebra_vxlan_if_vni_find (zebra_vxlan_if.c:661) ==443593== by 0x4EEAC3: zebra_vxlan_check_readd_vtep (zebra_vxlan.c:4244) ==443593== by 0x450967: netlink_macfdb_change (rt_netlink.c:3722) ==443593== by 0x450011: netlink_neigh_change (rt_netlink.c:4458) ''' Signed-off-by: Stephen Worley --- zebra/rt_netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/zebra/rt_netlink.c b/zebra/rt_netlink.c index 6fdae6ac4566..f9398b9eeabc 100644 --- a/zebra/rt_netlink.c +++ b/zebra/rt_netlink.c @@ -3635,7 +3635,7 @@ static int netlink_macfdb_change(struct nlmsghdr *h, int len, ns_id_t ns_id) return zebra_vxlan_if_vni_mcast_group_update(ifp, vni, NULL); - if (is_zero_mac(&mac)) + if (is_zero_mac(&mac) && vni) return zebra_vxlan_check_readd_vtep(ifp, vni, vtep_ip); return 0;