Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IP sorting issue #416

Closed
sysoppl opened this issue Oct 4, 2024 · 2 comments
Closed

IP sorting issue #416

sysoppl opened this issue Oct 4, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@sysoppl
Copy link

sysoppl commented Oct 4, 2024

Describe The Problem
Similar to #99
Sorting by IP is wrong

image
@sysoppl sysoppl added the bug Something isn't working label Oct 4, 2024
@donaldzou
Copy link
Owner

Hi! Yes I'm aware this issue.. Was trying to solve but when it comes to Peers containing multiple IP addresses, or IPv4 mixing with v6, is hard to sorting them "correctly". So I just did a Lexicographic sort to keep it simple ;) But if you have some good idea, please let me know!

@donaldzou
Copy link
Owner

Closing this for now. Will look for a better solution in the future :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@donaldzou @sysoppl