From 6128fcb1d135b5052d9ac43c87e535ed1d89ee54 Mon Sep 17 00:00:00 2001 From: Saif Billah Date: Sun, 26 Jul 2020 17:39:40 -0400 Subject: [PATCH 1/2] Added test case to highlight solution error, and added line to fix solution error. --- arrays_strings/str_diff/str_diff_solution.ipynb | 6 +++--- arrays_strings/str_diff/test_str_diff.py | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/arrays_strings/str_diff/str_diff_solution.ipynb b/arrays_strings/str_diff/str_diff_solution.ipynb index 48efa0c7..b0f27a9c 100644 --- a/arrays_strings/str_diff/str_diff_solution.ipynb +++ b/arrays_strings/str_diff/str_diff_solution.ipynb @@ -115,7 +115,7 @@ " if seen[char] < 0:\n", " return char\n", " for char, count in seen.items():\n", - " return char\n", + " if (count == 1): return char\n", "\n", " def find_diff_xor(self, str1, str2):\n", " if str1 is None or str2 is None:\n", @@ -159,7 +159,7 @@ " solution = Solution()\n", " self.assertRaises(TypeError, solution.find_diff, None)\n", " self.assertEqual(solution.find_diff('ab', 'aab'), 'a')\n", - " self.assertEqual(solution.find_diff('aab', 'ab'), 'a')\n", + " self.assertEqual(solution.find_diff('baa', 'ab'), 'a')\n", " self.assertEqual(solution.find_diff('abcd', 'abcde'), 'e')\n", " self.assertEqual(solution.find_diff('aaabbcdd', 'abdbacade'), 'e')\n", " self.assertEqual(solution.find_diff_xor('ab', 'aab'), 'a')\n", @@ -212,7 +212,7 @@ "name": "python", "nbconvert_exporter": "python", "pygments_lexer": "ipython3", - "version": "3.7.2" + "version": "3.7.6" } }, "nbformat": 4, diff --git a/arrays_strings/str_diff/test_str_diff.py b/arrays_strings/str_diff/test_str_diff.py index 0ff4c95b..79638db0 100644 --- a/arrays_strings/str_diff/test_str_diff.py +++ b/arrays_strings/str_diff/test_str_diff.py @@ -8,6 +8,7 @@ def test_find_diff(self): self.assertRaises(TypeError, solution.find_diff, None) self.assertEqual(solution.find_diff('ab', 'aab'), 'a') self.assertEqual(solution.find_diff('aab', 'ab'), 'a') + self.assertEqual(solution.find_diff('baa', 'ab'), 'a') self.assertEqual(solution.find_diff('abcd', 'abcde'), 'e') self.assertEqual(solution.find_diff('aaabbcdd', 'abdbacade'), 'e') self.assertEqual(solution.find_diff_xor('ab', 'aab'), 'a') From 923738a24d97605068a8d51b2bf381022ec7371e Mon Sep 17 00:00:00 2001 From: Saif Billah Date: Sun, 26 Jul 2020 17:43:17 -0400 Subject: [PATCH 2/2] Add original test case back --- arrays_strings/str_diff/str_diff_solution.ipynb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arrays_strings/str_diff/str_diff_solution.ipynb b/arrays_strings/str_diff/str_diff_solution.ipynb index b0f27a9c..c8ee4458 100644 --- a/arrays_strings/str_diff/str_diff_solution.ipynb +++ b/arrays_strings/str_diff/str_diff_solution.ipynb @@ -159,6 +159,7 @@ " solution = Solution()\n", " self.assertRaises(TypeError, solution.find_diff, None)\n", " self.assertEqual(solution.find_diff('ab', 'aab'), 'a')\n", + " self.assertEqual(solution.find_diff('aab', 'ab'), 'a')\n", " self.assertEqual(solution.find_diff('baa', 'ab'), 'a')\n", " self.assertEqual(solution.find_diff('abcd', 'abcde'), 'e')\n", " self.assertEqual(solution.find_diff('aaabbcdd', 'abdbacade'), 'e')\n", @@ -217,4 +218,4 @@ }, "nbformat": 4, "nbformat_minor": 1 -} +} \ No newline at end of file