Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix NativeEventEmitter warnings since ReactNative 0.65 #1524

Closed
wants to merge 1 commit into from

Conversation

sbin1211
Copy link
Contributor

@sbin1211 sbin1211 commented Oct 4, 2021

No description provided.

@radko93
Copy link
Contributor

radko93 commented Oct 13, 2021

@andresesfm can we edit the PR? It's not great that we cannot get it in just because of the spaces. I can create another PR if you want.

@hyochan hyochan added the 🍗 enhancement New feature or request label Oct 14, 2021
@hyochan
Copy link
Owner

hyochan commented Oct 14, 2021

Can someone check why the CI/build_android is failing?

@radko93
Copy link
Contributor

radko93 commented Oct 14, 2021

@hyochan there's still extra spacing for addListener
image

@andresesfm
Copy link
Contributor

@andresesfm can we edit the PR? It's not great that we cannot get it in just because of the spaces. I can create another PR if you want.

Go for it

@radko93
Copy link
Contributor

radko93 commented Oct 19, 2021

@andresesfm #1544

@andresesfm
Copy link
Contributor

Closed in favor of: #1544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍗 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants