Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support repositories cloned into subfolder #18

Closed
dorny opened this issue Jun 30, 2020 · 0 comments · Fixed by #21
Closed

Support repositories cloned into subfolder #18

dorny opened this issue Jun 30, 2020 · 0 comments · Fixed by #21
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@dorny
Copy link
Owner

dorny commented Jun 30, 2020

If repository is checked out into subfolder of $GITHUB_WORKSPACE, our change detection via git diff-index will fail. Checkout to subfolder is not common scenario but there are valid use cases for that. One example is checkout out multiple repositories.

Solution would be to add working-directory input parameter that would allow user to specify folder where change detection (i.e. git commands) should be executed. This option won't have any impact on change detection for pull requests using Github API.

@dorny dorny added the enhancement New feature or request label Jun 30, 2020
@dorny dorny added this to the v2.3.0 milestone Jun 30, 2020
@dorny dorny self-assigned this Jun 30, 2020
@dorny dorny closed this as completed in #21 Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant