From 750a0836007b3e1eb3d7ef34cc5312e723eec40a Mon Sep 17 00:00:00 2001 From: Michal Dorner Date: Mon, 14 Sep 2020 17:06:03 +0200 Subject: [PATCH 1/2] Rework README for v2.3 release --- CHANGELOG.md | 7 +- README.md | 418 +++++++++++++++++++++++++++++++++++++++------------ 2 files changed, 332 insertions(+), 93 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4f591ac2..fa93a87a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,10 @@ # Changelog +## v2.3.0 +- [Change detection using git "three dot" diff](https://github.com/dorny/paths-filter/pull/35) +- [Export files matching filter](https://github.com/dorny/paths-filter/pull/32) +- [Extend filter syntax with optional specification of file status: add, modified, deleted](https://github.com/dorny/paths-filter/pull/22) + ## v2.2.1 - [Add support for pull_request_target](https://github.com/dorny/paths-filter/pull/29) @@ -21,4 +26,4 @@ Updated dependencies - fixes github security alert ## v1.0.0 -First official release uploaded to marketplace. \ No newline at end of file +First official release uploaded to marketplace. diff --git a/README.md b/README.md index a683a105..e367db60 100644 --- a/README.md +++ b/README.md @@ -1,83 +1,151 @@ -

- paths-filter status -

-# Paths filter +# paths-filter -With this [Github Action](https://github.com/features/actions) you can execute your workflow steps only if relevant files are modified. +This [Github Action](https://github.com/features/actions) enables conditional execution of workflow steps and jobs, +based on the paths that are modified by pull request or in pushed commits. It saves time and resources especially in monorepo setups, where you can run slow tasks (e.g. integration tests or deployments) only for changed components. -Github workflows built-in [path filters](https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#onpushpull_requestpaths) +Github workflows built-in [path filters](https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#onpushpull_requestpaths) doesn't allow this because they doesn't work on a level of individual jobs or steps. -Supported workflows: -- Action triggered by **[pull_request](https://help.github.com/en/actions/reference/events-that-trigger-workflows#pull-request-event-pull_request)** event: - - changes detected against the pull request base branch -- Action triggered by **[push](https://help.github.com/en/actions/reference/events-that-trigger-workflows#push-event-push)** event: - - changes detected against the most recent commit on the same branch before the push - - changes detected against the top of the configured *base* branch (e.g. master) - -## Usage - -Filter rules are defined using YAML format. -Each filter has a name and set of rules. -Rule is a [glob expressions](https://github.com/isaacs/minimatch). -Optionally you specify if the file should be added, modified or deleted to be matched. -For each filter there will be corresponding output variable to indicate if there's a changed file matching any of the rules. -Output variables can be later used in the `if` clause to conditionally run specific steps. - -### Inputs -- **`token`**: GitHub Access Token - defaults to `${{ github.token }}` so you don't have to explicitly provide it. -- **`working-directory`: Relative path under $GITHUB_WORKSPACE where the repository was checked out. Useful only if you checked out your repository under custom path. -- **`base`**: Git reference (e.g. branch name) against which the changes will be detected. Defaults to repository default branch (e.g. master). - If it references same branch it was pushed to, changes are detected against the most recent commit before the push. - This option is ignored if action is triggered by *pull_request* event. -- **`filters`**: Path to the configuration file or directly embedded string in YAML format. - -### Outputs -- For each rule it sets output variable named by the rule to text: - - `'true'` - if **any** of changed files matches any of rule patterns - - `'false'` - if **none** of changed files matches any of rule patterns - -### Notes -- minimatch [dot](https://www.npmjs.com/package/minimatch#dot) option is set to true - therefore - globbing will match also paths where file or folder name starts with a dot. -- You can use YAML anchors to reuse path expression(s) inside another rule. See example in the tests. -- It's recommended to put quote your path expressions with `'` or `"`. Otherwise you will get an error if it starts with `*`. -- If changes are detected against the previous commit and there is none (i.e. first push of a new branch), all filter rules will report changed files. -- You can use `base: ${{ github.ref }}` to configure change detection against previous commit for every branch you create. - -### Example + +## Supported workflows: +- Pull requests: + - Action triggered by **[pull_request](https://docs.github.com/en/actions/reference/events-that-trigger-workflows#pull_request)** + or **[pull_request_target](https://docs.github.com/en/actions/reference/events-that-trigger-workflows#pull_request_target)** event + - Changes are detected against the pull request base branch + - Uses Github REST API to fetch list of modified files +- Feature branches: + - Action triggered by **[push](https://docs.github.com/en/actions/reference/events-that-trigger-workflows#push)** event + - Changes are detected against the merge-base with configured base branch + - Uses git commands to detect changes - repository must be already [checked out](https://github.com/actions/checkout) +- Master, Release or other long-lived branches: + - Action triggered by **[push](https://docs.github.com/en/actions/reference/events-that-trigger-workflows#push)** event + - Changes are detected against the most recent commit on the same branch before the push + - Uses git commands to detect changes - repository must be already [checked out](https://github.com/actions/checkout) + + +## Important notes: +- Paths expressions are evaluated using [minimatch](https://github.com/isaacs/minimatch) library. + Documentation for path expression format can be found on project github page. +- Minimatch [dot](https://www.npmjs.com/package/minimatch#dot) option is set to true. + Globbing will match also paths where file or folder name starts with a dot. +- It's recommended to quote your path expressions with `'` or `"`. Otherwise you will get an error if it starts with `*`. + + +# What's New + +- Fixed behavior of feature branch workflow: + - Detects only changes introduced by feature branch. Later modifications on base branch are ignored. +- Filter by type of file change: + - Optionally consider if file was added, modified or deleted +- Custom processing of changed files: + - Optionally export paths of all files matching the filter + - Output can be space-delimited or in JSON format +- Improved documentation and logging + +For more information see [CHANGELOG](https://github.com/actions/checkout/blob/main/CHANGELOG.md) + +# Usage + +```yaml +- uses: dorny/paths-filter@v2 + with: + # Defines filters applied to detected changed files. + # Each filter has a name and list of rules. + # Rule is a glob expression - paths of all changed + # files are matched against it. + # Rule can optionally specify if the file + # should be added, modified or deleted. + # For each filter there will be corresponding output variable to + # indicate if there's a changed file matching any of the rules. + # Optionally there can be a second output variable + # set to list of all files matching the filter. + # Filters can be provided inline as a string (containing valid YAML document) + # or as a relative path to separate file (e.g.: .github/filters.yaml). + # Multiline string is evaluated as embedded filter definition, + # single line string is evaluated as relative path to separate file. + # Filters syntax is documented by example - see examples section. + filters: '' + + # Branch against which the changes will be detected. + # If it references same branch it was pushed to, + # changes are detected against the most recent commit before the push. + # Otherwise it uses git merge-base to find best common ancestor between + # current branch (HEAD) and base. + # When merge-base is found, it's used for change detection - only changes + # introduced by current branch are considered. + # All files are considered as added if there is no common ancestor with + # base branch or no previous commit. + # This option is ignored if action is triggered by pull_request event. + # Default: repository default branch (e.g. master) + base: '' + + # How many commits are initially fetched from base branch. + # If needed, each subsequent fetch doubles the + # previously requested number of commits until the merge-base + # is found or there are no more commits in the history. + # This option takes effect only when changes are detected + # using git against base branch (feature branch workflow). + # Default: 20 + initial-fetch-depth: '' + + # Enables listing of files matching the filter: + # 'none' - Disables listing of matching files (default). + # 'json' - Matching files paths are formatted as JSON array. + # 'shell' - Matching files paths are escaped and space-delimited. + # Output is usable as command line argument list in linux shell. + # Default: none + list-files: '' + + # Relative path under $GITHUB_WORKSPACE where the repository was checked out. + working-directory: '' + + # Personal access token used to fetch list of changed files + # from Github REST API. + # It's used only if action is triggered by pull request event. + # Github token from workflow context is used as default value. + # If empty string is provided, action falls back to detect + # changes using git commands. + # Default: ${{ github.token }} + token: '' +``` + +## Outputs +- For each filter it sets output variable named by the filter to the text: + - `'true'` - if **any** of changed files matches any of filter rules + - `'false'` - if **none** of changed files matches any of filter rules +- If enabled, for each filter it sets output variable with name `${FILTER_NAME}_files`. It will contain list of all files matching the filter. + +# Examples + +## Conditional execution + +
+ Execute step in a workflow job only if some file in a subfolder is changed + ```yaml -on: - push: - branches: - - master - pull_request: - branches: - - master jobs: tests: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - - uses: dorny/paths-filter@v2.2.1 + - uses: dorny/paths-filter@v2 id: filter with: - # inline YAML or path to separate file (e.g.: .github/filters.yaml) filters: | backend: - - 'backend/**/*' + - 'backend/**' frontend: - - 'frontend/**/*' + - 'frontend/**' # run only if 'backend' files were changed - - name: backend unit tests + - name: backend tests if: steps.filter.outputs.backend == 'true' run: ... # run only if 'frontend' files were changed - - name: frontend unit tests + - name: frontend tests if: steps.filter.outputs.frontend == 'true' run: ... @@ -86,16 +154,14 @@ jobs: if: steps.filter.outputs.backend == 'true' || steps.filter.outputs.frontend == 'true' run: ... ``` +
+ +
+ Execute job in a workflow only if some file in a subfolder is changed -If your workflow uses multiple jobs, you can put *paths-filter* into own job and use -[job outputs](https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjobs_idoutputs) -in other jobs [if](https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idif) statements: ```yml -on: - pull_request: - branches: - - master jobs: + # JOB to run change detection changes: runs-on: ubuntu-latest # Set job outputs to values from filter step @@ -104,45 +170,213 @@ jobs: frontend: ${{ steps.filter.outputs.frontend }} steps: # For pull requests it's not necessary to checkout the code - - uses: dorny/paths-filter@v2.2.1 + - uses: dorny/paths-filter@v2 id: filter with: - # Filters stored in own yaml file - filters: '.github/filters.yml' + filters: | + backend: + - 'backend/**' + frontend: + - 'frontend/**' + + # JOB to build and test backend code backend: needs: changes if: ${{ needs.changes.outputs.backend == 'true' }} + runs-on: ubuntu-latest steps: + - uses: actions/checkout@v2 - ... + + # JOB to build and test frontend code frontend: needs: changes if: ${{ needs.changes.outputs.frontend == 'true' }} + runs-on: ubuntu-latest steps: + - uses: actions/checkout@v2 - ... ``` +
+ +## Change detection workflows + +
+ Pull requests: Detect changes against PR base branch + +```yaml +on: + pull_request: + branches: # PRs to following branches will trigger the workflow + - master + - develop +jobs: + build: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - uses: dorny/paths-filter@v2 + id: filter + with: + filters: ... # Configure your filters +``` +
+ +
+ Feature branch: Detect changes against configured base branch + +```yaml +on: + push: + branches: # Push to following branches will trigger the workflow + - feature/** +jobs: + build: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - uses: dorny/paths-filter@v2 + id: filter + with: + base: develop # Change detection against merge-base with this branch + filters: ... # Configure your filters +``` +
+ +
+ Long lived branches: Detect changes against the most recent commit on the same branch before the push + +```yaml +on: + push: + branches: # Push to following branches will trigger the workflow + - master + - develop + - release/** +jobs: + build: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - uses: dorny/paths-filter@v2 + id: filter + with: + # Use context to get branch where commits were pushed. + # If there is only one long lived branch (e.g. master), + # you can specify it directly. + # If it's not configured, the repository default branch is used. + base: ${{ github.ref }} + filters: ... # Configure your filters +``` +
+ +## Advanced options + +
+ Define filter rules in own file + +```yaml +- uses: dorny/paths-filter@v2 + id: filter + with: + # Path to file where filters are defined + filters: .github/filters.yaml +``` +
+ +
+ Use YAML anchors to reuse path expression(s) inside another rule + +```yaml +- uses: dorny/paths-filter@v2 + id: filter + with: + # &shared is YAML anchor, + # *shared references previously defined anchor + # src filter will match any path under common, config and src folders + filters: | + shared: &shared + - common/** + - config/** + src: + - *shared + - src/** +``` +
+ +
+ Consider if file was added, modified or deleted + +```yaml +- uses: dorny/paths-filter@v2 + id: filter + with: + # Changed file can be 'added', 'modified', or 'deleted'. + # By default the type of change is not considered. + # Optionally it's possible to specify it using nested + # dictionary, where type(s) of change composes the key. + # Multiple change types can be specified using `|` as delimiter. + filters: | + addedOrModified: + - added|modified: '**' + allChanges: + - added|deleted|modified: '**' +``` +
+ + +## Custom processing of changed files + +
+ Passing list of modified files as command line args in Linux shell + +```yaml +- uses: dorny/paths-filter@v2 + id: filter + with: + # Enable listing of files matching each filter. + # Paths to files will be available in `${FILTER_NAME}_files` output variable. + # Paths will be escaped and space-delimited. + # Output is usable as command line argument list in linux shell + list-files: shell + + # In this example changed files will be checked by linter. + # It doesn't make sense to lint deleted files. + # Therefore we specify we are only interested in added or modified files. + filters: | + markdown: + - added|modified: '*.md' +- name: Lint Markdown + if: ${{ steps.filter.outputs.markdown == 'true' }} + run: npx textlint ${{ steps.filter.outputs.markdown_files }} +``` +
+ +
+ Passing list of modified files as JSON array to another action + +```yaml +- uses: dorny/paths-filter@v2 + id: filter + with: + # Enable listing of files matching each filter. + # Paths to files will be available in `${FILTER_NAME}_files` output variable. + # Paths will be formatted as JSON array + list-files: json + + # In this example all changed files are passed to following action to do + # some custom processing. + filters: | + changed: + - '**' +- name: Lint Markdown + uses: johndoe/some-action@v1 + with: + files: ${{ steps.filter.changed_files }} +``` +
+ + +# License -## How it works - -1. If action was triggered by pull request: - - If access token was provided it's used to fetch list of changed files from Github API. - - If access token was not provided, top of the base branch is fetched and changed files are detected using `git diff-index ` command. -2. If action was triggered by push event - - if *base* input parameter references same branch it was pushed to, most recent commit before the push is fetched - - If *base* input parameter references other branch, top of that branch is fetched - - changed files are detected using `git diff-index FETCH_HEAD` command. -3. For each filter rule it checks if there is any matching file -4. Output variables are set - -## Difference from similar projects: - -- [Has Changed Path](https://github.com/MarceloPrado/has-changed-path) - - detects changes from previous commit - - you have to configure `checkout` action to fetch some number of previous commits - - outputs only single `true` / `false` value if any of provided paths contains changes -- [Changed Files Exporter](https://github.com/futuratrepadeira/changed-files) - - outputs lists with paths of created, updated and deleted files - - output is not directly usable in the `if` clause -- [Changed File Filter](https://github.com/tony84727/changed-file-filter) - - allows change detection between any refs or commits - - fetches whole history of your git repository - - might have negative performance impact on big repositories (github by default fetches only single commit) +The scripts and documentation in this project are released under the [MIT License](https://github.com/dorny/paths-filter/blob/master/LICENSE) From 48f38faa39c675fcdd590ffde276e5ccd0ac6517 Mon Sep 17 00:00:00 2001 From: Michal Dorner Date: Mon, 14 Sep 2020 17:11:57 +0200 Subject: [PATCH 2/2] add current PR to change log --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index fa93a87a..dad57fa8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,7 @@ # Changelog ## v2.3.0 +- [Improved documentation](https://github.com/dorny/paths-filter/pull/37) - [Change detection using git "three dot" diff](https://github.com/dorny/paths-filter/pull/35) - [Export files matching filter](https://github.com/dorny/paths-filter/pull/32) - [Extend filter syntax with optional specification of file status: add, modified, deleted](https://github.com/dorny/paths-filter/pull/22)