Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/clarity #467

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Refactor/clarity #467

merged 3 commits into from
Dec 7, 2023

Conversation

rkrishnasanka
Copy link
Contributor

I'm starting to make some changes to the code documentation here. I'm including a bit of refactoring to make sure that things are more readable.

  • The code extensively uses the short variable names to the detriment of the readability. This compounds the problem of not having enough code documentation.

  • While golang recommends short variable names, the intention is to avoid long nested function calls and to avoid diverting the attention from the main logic of the program. However, even the main logic variables have really short names making it almost impossible to read.

I'm starting to make some changes to the code documentation here. I'm including a bit of refactoring to make sure that things are more readable.

- The code extensively uses the short variable names to the detriment of the readability. This compounds the problem of not having enough code documentation.

- While golang recommends short variable names, the intention is to avoid long nested function calls and to avoid diverting the attention from the main logic of the program. However, even the main logic variables have really short names making it almost impossible to read.
Copy link

vercel bot commented Dec 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graphjin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2023 10:34am

@CLAassistant
Copy link

CLAassistant commented Dec 4, 2023

CLA assistant check
All committers have signed the CLA.

@dosco dosco marked this pull request as ready for review December 7, 2023 10:28
@dosco dosco merged commit 347b070 into dosco:master Dec 7, 2023
6 checks passed
rkrishnasanka added a commit to rkrishnasanka/graphjin that referenced this pull request Apr 15, 2024
* Updated the  basic documentation example

* Improving code clarity
I'm starting to make some changes to the code documentation here. I'm including a bit of refactoring to make sure that things are more readable.

- The code extensively uses the short variable names to the detriment of the readability. This compounds the problem of not having enough code documentation.

- While golang recommends short variable names, the intention is to avoid long nested function calls and to avoid diverting the attention from the main logic of the program. However, even the main logic variables have really short names making it almost impossible to read.

* Incremental renaming of variables in intro.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants