Incompatible Typescript Cache type when using createRedisCache

[AdamJHall]

Describe the bug

When using @graphql-yoga/plugin-response-cache plugin, and following the documented example here: https://the-guild.dev/graphql/yoga-server/docs/features/response-caching#external-cache to provide a createRedisCache cache instance causes a Typescript error:

Type 'import("node_modules/@envelop/response-cache/typings/cache").Cache' is not assignable to type 'Cache'.
  The types returned by 'get(...)' are incompatible between these types.
    Type 'PromiseOrValue<Maybe<ExecutionResult<ObjMap<unknown>, ObjMap<unknown>>>>' is not assignable to type 'Promise<ExecutionResult<Record<string, unknown>, ResponseCachePluginExtensions> | undefined>'.
      Type 'undefined' is not assignable to type 'Promise<ExecutionResult<Record<string, unknown>, ResponseCachePluginExtensions> | undefined>'.ts(2322)
index.d.ts(8, 5): The expected type comes from property 'cache' which is declared here on type 'UseResponseCacheParameter'

Your Example Website or App

https://codesandbox.io/p/sandbox/determined-carlos-7qx3nj?file=%2Fsrc%2Fmain.ts%3A32%2C31

Steps to Reproduce the Bug or Issue

Create a Typescript instance of Yoga using the useResponseCache plugin, with the cache option set to a cache instance created with createRedisCache.

Expected behavior

The server should start without any typescript compilation errors.

Screenshots or Videos

No response

Platform

• @envelop/response-cache-redis 3.3.2
• @graphql-yoga/plugin-response-cache 2.2.0
• graphql-yoga 4.0.5

Additional context

Seems to be similar to: #2905

[sutt0n]

Can confirm, this is still an issue.

[jasonkuhrt]

Repro:

Links:

• https://github.com/dotansimha/graphql-yoga/blob/main/packages/plugins/response-cache/src/index.ts#L73-L79
• https://github.com/n1ru4l/envelop/blob/main/packages/plugins/response-cache/src/cache.ts#L25 (last update, 1 year)

Next to check:

• Are types only different b/c of missing dep updates in some chain somewhere
• If no, what's intended type currently. Then do update, make release, make updates.

[jasonkuhrt]

I have a solution locally based on changing the Envelop plugins. Need access to https://github.com/n1ru4l/envelop to make my PR. I'll check with the team about it tomorrow.