Skip to content

Commit a5f3ebe

Browse files
committed
Remove workflow comment
Fixes dotnet#1498
1 parent 844e6f0 commit a5f3ebe

File tree

2 files changed

+1
-34
lines changed

2 files changed

+1
-34
lines changed

Infrastructure/src/TriageBuildFailures/GitHub/GitHubClientWrapperExtensions.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,7 @@ public static async Task CommentOnBuild(this GitHubClientWrapper gitHubClient, I
8080
var botCommentsFromToday = comments.Where(c =>
8181
c.CreatedAt.Date == DateTime.UtcNow.Date
8282
&& c.User.Login == gitHubClient.Config.BotUsername
83-
&& c.Body.Contains("This comment was made automatically")
84-
&& !c.Body.Contains("Please use this workflow"));
83+
&& c.Body.Contains("This comment was made automatically"));
8584

8685
var commentsAboutThisBuild = comments.Where(c => c.Body.Contains(build.WebURL.ToString()));
8786

Infrastructure/src/TriageBuildFailures/Handlers/HandleTestFailures.cs

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -44,36 +44,6 @@ private string TrimTestFailureText(string text)
4444
return result;
4545
}
4646

47-
private const string WorkFlowComment = @"Please use this workflow to address this flaky test issue, including checking applicable checkboxes and filling in the applicable ""TODO"" entries:
48-
49-
* Is this actually a flaky test?
50-
* No, this is a regular test failure, fix the test/product (TODO: Link to commit/PR)
51-
* Yes, proceed below...
52-
53-
* Is this test failure caused by product code flakiness? (Either this product, or another product this test depends on.)
54-
* [ ] File a bug against the product (TODO: Link to other bug)
55-
* Is it possible to change the test to avoid the flakiness?
56-
* Yes? Go to the ""Change the test!"" section.
57-
* No?
58-
* [ ] Disable the test (TODO: Link to PR/commit)
59-
* [ ] Wait for other bug to be resolved
60-
* [ ] Wait for us to get build that has the fix
61-
* [ ] Re-enable our test (TODO: Link to PR/commit)
62-
* [ ] Close this bug
63-
64-
* Is it that the test itself is flaky? This includes external transient problems (e.g. remote server problems, file system race condition, etc.)
65-
* Is there is a way to change our test to avoid this flakiness?
66-
* Yes? Change the test!
67-
* [ ] Change the test to avoid the flakiness, for example by using a different test strategy, or by adding retries w/ timeouts (TODO: Link to PR/commit)
68-
* [ ] Run the test 100 times locally as a sanity check.
69-
* [ ] Close this bug
70-
* No?
71-
* Is there any logging or extra information that we could add to make this more diagnosable when it happens again?
72-
* Yes?
73-
* [ ] Add the logging (TODO: Link to PR/commit)
74-
* No?
75-
* [ ] Delete the test because flaky tests are not useful (TODO: Link to PR/commit)";
76-
7747
public override async Task HandleFailure(ICIBuild build)
7848
{
7949
var client = GetClient(build);
@@ -131,8 +101,6 @@ This test failed on {build.Branch}.
131101
Reporter.Output($"Creating new issue for test failure {failure.Name}...");
132102
var issue = await GHClient.CreateIssue(owner, repo, subject, body, issueLabels, assignees);
133103
Reporter.Output($"Created issue {issue.HtmlUrl}");
134-
Reporter.Output($"Adding workflow comment to issue {issue.HtmlUrl}");
135-
await GHClient.CreateComment(issue, WorkFlowComment);
136104
}
137105
// The issue already exists, comment on it if we haven't already done so for this build.
138106
else

0 commit comments

Comments
 (0)