Handle mixed multidimensional/jagged arrays properly (fixes #2893) #2894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User0332
force-pushed
the
fix-issue-2893
branch
from
f1a0445 to
2950715
Compare
Collaborator
|
Please fix merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2893 (both display type & codegen)
Added a test to
ArgumentsTestsfor this behavior.The commit history is a little messy because I forgot to create a new branch for this issue so I had to drop some commits from #2892
For
ArrayParam.csthis branch's changes should take priority over #2892 because it should support the same behavior.