Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configurable access modifier using star #323

Closed
ThomasGoulet73 opened this issue Feb 12, 2022 · 1 comment
Closed

Allow configurable access modifier using star #323

ThomasGoulet73 opened this issue Feb 12, 2022 · 1 comment

Comments

@ThomasGoulet73
Copy link

Currently, --with-access-specifier *=internal does not seem to work and I think it would be useful when you want to generate internal bindings. Passing true as the fourth parameter in the call to TryGetRemappedValue here seems to fix this issue:

if (!TryGetRemappedValue(namedDecl, _config.WithAccessSpecifiers, out var accessSpecifier) || (accessSpecifier == AccessSpecifier.None))

I'm not very familiar with this codebase so I'll let the maintainers decide if this is the right fix and I would be happy to submit a PR.

@tannergooding
Copy link
Member

This was resolved with #359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants