Updating to use the latest System.CommandLine #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| aliases: new string[] { "--file-directory", "-F" }, | ||
| description: "The base path for files to parse.", | ||
| argumentType: typeof(string), | ||
| getDefaultValue: () => string.Empty, | ||
| arity: ArgumentArity.ExactlyOne |
There was a problem hiding this comment.
What, if anything, controls the arity allowed now and therefore errors if more than one --file-directory is specified?
There was a problem hiding this comment.
This is now defaulted based on the generic type of the option (which is forwarded to the option's argument).
It can be overridden by specifying a specific value for the Arity property, however it appeared that the options here were all following the defaults.
You can see the default Arity for different types here: https://github.com/dotnet/command-line-api/blob/main/src/System.CommandLine/ArgumentArity.cs#L144-L168
tannergooding
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to keep the structure similar to what was there previously.
Some notable differences.
CommandLineBuilderdirectly because callingCommand.Invokewith and option that matched the--versioncaused an error with a duplicate symbol.[]where before it was[default: ]HelpContextI believe this API could be improved in System.CommandLine to make this easier.