Do not remove parethensis #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's potentially risky move on real codebases, but that's not captured anywhere in tests, so I will move ahead with a change. Would be good if somebody test that on some larger codebase and check how it works for them. Most other changes is only in testing infra. I take liberty and do following change operating from following premises. - there only 2 radically different output formats: CSharp and Xml - Most codegeneration would be platform neutral. - You will need to override tests based on platform needs (like it is right now) I do trying not create sets of identical tests for each platform, since it's a bit boring and timeconsuming to validate. For example using existing approach not clear what's platform-independent behaviour and what is OS specific behavior of ClangSharp. After this change all platform independent tests may sit in Base folder, and additional tests and/or augmentations will be in same location as it is now. Fixes dotnet#357
kant2002
force-pushed
the
kant/fix-unwrap
branch
from
184bb62
to
b5fb74d
Compare
|
Validated against a few various projects and no issues seen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's potentially risky move on real codebases, but that's not captured anywhere in tests, so I will move ahead with a change.
Would be good if somebody test that on some larger codebase and check how it works for them.
Most other changes is only in testing infra. I take liberty and do following change operating from following premises.
I do trying not create sets of identical tests for each platform, since it's a bit boring and timeconsuming to validate. For example using existing approach not clear what's platform-independent behaviour and what is OS specific behavior of ClangSharp. After this change all platform independent tests may sit in Base folder, and additional tests and/or augmentations will be in same location as it is now.
Fixes #357