Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance guidelines #2934

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Performance guidelines #2934

merged 1 commit into from
Dec 17, 2020

Conversation

roji
Copy link
Member

@roji roji commented Dec 9, 2020

Here's a draft for a new performance guidelines section, any and all feedback is welcome.

Note that code is currently inline, I will separate it out into the samples before merging.

Closes #212
Closes #2608
Closes #2902

@roji roji requested a review from a team December 9, 2020 14:54
@roji roji force-pushed the Perf branch 4 times, most recently from 11dacd2 to 9ba9eff Compare December 9, 2020 15:08
entity-framework/core/miscellaneous/async.md Outdated Show resolved Hide resolved

## DbContext pooling

`AddDbContextPool` enables pooling of `DbContext` instances. Context pooling can increase throughput in high-scale scenarios such as web servers by reusing context instances, rather than creating new instances for each request.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move the last sentence in this topic up here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you referring to the paragraph that starts with "Context pooling is intended for scenarios where the context configuration, which includes services resolved, is fixed between requests."? It seems OK to me under the limitations, what do you have in mind?

@ErikEJ
Copy link
Contributor

ErikEJ commented Dec 9, 2020

Revival of the EF6 performance white paper ? 🥳

@roji
Copy link
Member Author

roji commented Dec 9, 2020

Revival of the EF6 performance white paper ?

Yep :)

@roji roji force-pushed the Perf branch 8 times, most recently from 84c08ae to e133776 Compare December 14, 2020 12:15
@roji roji marked this pull request as ready for review December 14, 2020 12:19
Copy link
Contributor

@bricelam bricelam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑🇮🇹

Loved this. So much good information with a clean layout. You may want to run a grammar and spell check before merging, since I didn't bother marking the ones I saw while reading it. (Since I read the rendered preview on my phone.)

@roji
Copy link
Member Author

roji commented Dec 17, 2020

Thanks for the reviews and feedback :)

Closes #212
Closes #2608
Closes #2902
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants