diff --git a/src/Nerdbank.GitVersioning.Tasks/build/Nerdbank.GitVersioning.targets b/src/Nerdbank.GitVersioning.Tasks/build/Nerdbank.GitVersioning.targets index 9444314c..1aa185c2 100644 --- a/src/Nerdbank.GitVersioning.Tasks/build/Nerdbank.GitVersioning.targets +++ b/src/Nerdbank.GitVersioning.Tasks/build/Nerdbank.GitVersioning.targets @@ -40,8 +40,31 @@ false false - - false + + <_NBGV_LanguageMode Condition=" '$(Language)' == 'c++' ">Native + <_NBGV_LanguageMode Condition=" '$(Language)' == 'c#' ">Managed + <_NBGV_LanguageMode Condition=" '$(Language)' == 'cs' ">Managed + <_NBGV_LanguageMode Condition=" '$(Language)' == 'csharp' ">Managed + <_NBGV_LanguageMode Condition=" '$(Language)' == 'vb' ">Managed + <_NBGV_LanguageMode Condition=" '$(Language)' == 'visualbasic' ">Managed + <_NBGV_LanguageMode Condition=" '$(Language)' == 'visual basic' ">Managed + <_NBGV_LanguageMode Condition=" '$(Language)' == 'f#' ">Managed + <_NBGV_LanguageMode Condition=" '$(Language)' == 'fs' ">Managed + <_NBGV_LanguageMode Condition=" '$(Language)' == 'fsharp' ">Managed + + false @@ -115,7 +138,7 @@ - + $([MSBuild]::NormalizePath('$(IntermediateOutputPath)', '$(AssemblyName).Version$(DefaultLanguageSourceExtension)')) $(VersionSourceFile).new @@ -162,7 +185,7 @@ - + $([MSBuild]::NormalizePath('$(IntermediateOutputPath)', '$(AssemblyName).Version.rc')) $(VersionSourceFile).new diff --git a/test/Nerdbank.GitVersioning.Tests/BuildIntegrationTests.cs b/test/Nerdbank.GitVersioning.Tests/BuildIntegrationTests.cs index c694b991..54e9bab2 100644 --- a/test/Nerdbank.GitVersioning.Tests/BuildIntegrationTests.cs +++ b/test/Nerdbank.GitVersioning.Tests/BuildIntegrationTests.cs @@ -192,25 +192,6 @@ public async Task AssemblyInfo_HasKeyData(string keyFile, bool delaySigned) } } - /// - /// Emulate a project with an unsupported language, and verify that - /// one warning is emitted because the assembly info file couldn't be generated. - /// - [Fact] - public async Task AssemblyInfo_NotProducedWithoutCodeDomProvider() - { - ProjectPropertyGroupElement propertyGroup = this.testProject.CreatePropertyGroupElement(); - this.testProject.AppendChild(propertyGroup); - propertyGroup.AddProperty("Language", "NoCodeDOMProviderForThisLanguage"); - - this.WriteVersionFile(); - BuildResults result = await this.BuildAsync(Targets.GenerateAssemblyNBGVVersionInfo, logVerbosity: LoggerVerbosity.Minimal, assertSuccessfulBuild: false); - Assert.Equal(BuildResultCode.Failure, result.BuildResult.OverallResult); - string versionCsFilePath = Path.Combine(this.projectDirectory, result.BuildResult.ProjectStateAfterBuild.GetPropertyValue("VersionSourceFile")); - Assert.False(File.Exists(versionCsFilePath)); - Assert.Single(result.LoggedEvents.OfType()); - } - /// /// Emulate a project with an unsupported language, and verify that /// no errors are emitted because the target is skipped.