address review comments

src/Directory.Build.props

@@ -42,6 +42,7 @@
  <ToolsArtifactsDir Condition="'$(ToolsArtifactsDir)'==''">$(Artifacts)tools\</ToolsArtifactsDir>
  <ManagedSourceCode>$(ProjectDir)Microsoft.Data.SqlClient\</ManagedSourceCode>
  <NetCoreSource>$(ManagedSourceCode)netcore\</NetCoreSource>
+ <NetCoreResources>$(ManagedSourceCode)netcore\src\Resources\</NetCoreResources>
  <NetFxSource>$(ManagedSourceCode)netfx\</NetFxSource>
  <NetFxResources>$(ManagedSourceCode)netfx\src\Resources\</NetFxResources>
  <AddOnsPath>$(ManagedSourceCode)add-ons\</AddOnsPath>

src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj

@@ -18,6 +18,8 @@
  <DocumentationFile>$(OutputPath)\$(TargetFramework)\Microsoft.Data.SqlClient.xml</DocumentationFile>
  <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
  <Product>Core $(BaseProduct)</Product>
+ <ResxFileName>Strings</ResxFileName>
+ <GeneratedSourceFileName>$(ResxFileName).ResourceNames.cs</GeneratedSourceFileName>
  </PropertyGroup>
  <PropertyGroup Condition="'$(TargetGroup)' == 'netcoreapp'">
  <DefineConstants>$(DefineConstants);NETCOREAPP;</DefineConstants>
@@ -327,6 +329,9 @@
  <Compile Include="..\..\src\Resources\ResCategoryAttribute.cs">
  <Link>Resources\ResCategoryAttribute.cs</Link>
  </Compile>
+ <Compile Include="..\..\src\Resources\ResDescriptionAttribute.cs">
+ <Link>Resources\ResDescriptionAttribute.cs</Link>
+ </Compile>
  </ItemGroup>
  <ItemGroup Condition="'$(TargetGroup)' == 'netstandard' OR '$(TargetGroup)' == 'netcoreapp' OR '$(IsUAPAssembly)' == 'true'">
  <Compile Include="Microsoft.Data.SqlClient.TypeForwards.cs" />
@@ -873,4 +878,5 @@
  <Import Project="$(ToolsDir)targets\GenerateThisAssemblyCs.targets" />
  <Import Project="$(ToolsDir)targets\ResolveContract.targets" Condition="'$(OSGroup)' == 'AnyOS'" />
  <Import Project="$(ToolsDir)targets\NotSupported.targets" Condition="'$(OSGroup)' == 'AnyOS'" />
+ <Import Project="$(NetCoreSource)tools\targets\GenerateResourceStringsSource.targets" />
 </Project>

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnectionStringBuilder.NetCoreApp.cs

@@ -2,6 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+using System;
+using System.ComponentModel;
 using System.Data.Common;
 using System.Diagnostics;
 using Microsoft.Data.Common;
@@ -24,6 +26,10 @@ private static PoolBlockingPeriod ConvertToPoolBlockingPeriod(string keyword, ob
  }
 
  /// <include file='../../../../../../../doc/snippets/Microsoft.Data.SqlClient/SqlConnectionStringBuilder.xml' path='docs/members[@name="SqlConnectionStringBuilder"]/PoolBlockingPeriod/*' />
+ [DisplayNameAttribute(DbConnectionStringKeywords.PoolBlockingPeriod)]
+ [ResCategoryAttribute(StringsHelper.ResourceNames.DataCategory_Pooling)]
+ [ResDescriptionAttribute(StringsHelper.ResourceNames.DbConnectionString_PoolBlockingPeriod)]
+ [RefreshPropertiesAttribute(RefreshProperties.All)]
  public PoolBlockingPeriod PoolBlockingPeriod
  {
  get { return _poolBlockingPeriod; }