From 6ce2966b1435108ae389e77f2afb6ba61537ac9a Mon Sep 17 00:00:00 2001 From: Wraith2 Date: Wed, 24 Jun 2020 09:13:13 +0100 Subject: [PATCH] address feedback --- .../src/Microsoft/Data/SqlClient/AAsyncCallContext.cs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/AAsyncCallContext.cs b/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/AAsyncCallContext.cs index c70724a1be..56e369593a 100644 --- a/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/AAsyncCallContext.cs +++ b/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/AAsyncCallContext.cs @@ -11,11 +11,11 @@ namespace Microsoft.Data.SqlClient // avoiding the use of closures and allowing caching/reuse of the instances for frequently used async // calls // - // DO derive from this and seal and your class + // DO derive from this and seal your class // DO add additional fields or properties needed for the async operation and then override Clear to zero them // DO override AfterClear and use the owner parameter to return the object to a cache location if you have one, this is the purpose of the method // CONSIDER creating your own Set method that calls the base Set rather than providing a parameterized ctor, it is friendlier to caching - // DO NOT use this class after Dispose has been called. It will not throw ObjectDisposedException but it will be a cleared object + // DO NOT use this class' state after Dispose has been called. It will not throw ObjectDisposedException but it will be a cleared object internal abstract class AAsyncCallContext : IDisposable where TOwner : class @@ -50,7 +50,7 @@ protected void ClearCore() } /// - /// overrride this method to cleanup instance data before ClearCore is called which will blank the base data + /// override this method to cleanup instance data before ClearCore is called which will blank the base data /// protected virtual void Clear() { @@ -61,7 +61,6 @@ protected virtual void Clear() /// protected virtual void AfterCleared(TOwner owner) { - } public void Dispose()