Move to Shared for TdsEnums.cs #1369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and fix netfx build due to typo in enum
cheenamalhotra
added
the
➕ Code Health
…and to verify out of range for LocaleId
…rator and GetService for netfx and CreateCommandBuilder for both
added 6 commits
January 4, 2022 12:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1261 , I merged the netfx version into netcore of TdsEnum and moved it into shared src. There was a typo in TdsParser in netfx referencing the enum, so that's why it was modified and cleaned up the IDE0090 coding style info messages but I left the IDE1006 because those static variables are public and I didn't want to modify the public api.