Code Health | Cleanup SNIMARSConnection
#1985
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #933 many changes were made to SNIMarsConnection which were then lost when that PR was reverted. This PR implements the harmless and side-effect-less changes such as using scoped event tracing like the rest of SNI does, cleaning up a class name variable and adding a dedicated sync object (there are no locks on instances of this class outside this file, i've checked).
This does not change the demuxing code in any way. I want to get the files cleaned up and then try again with the muxing code in a future PR. this is a simple way to get easy changes in place minimizing review complexity.