Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed link to release notes #2

Merged
merged 1 commit into from
May 7, 2019
Merged

Conversation

phillip-haydon
Copy link
Contributor

Release notes current url goes to 1.0.0 folder which doesn't exist as the release notes are in the root folder of the readme.

Release notes current url goes to `1.0.0` folder which doesn't exist as the release notes are in the root folder of the readme.
@David-Engel
Copy link
Contributor

Oops. Nice catch! Thanks!

@David-Engel David-Engel merged commit 3fffbe4 into dotnet:master May 7, 2019
yukiwongky pushed a commit to yukiwongky/SqlClient that referenced this pull request Nov 5, 2019
Release notes current url goes to `1.0.0` folder which doesn't exist as the release notes are in the root folder of the readme.
johnnypham pushed a commit that referenced this pull request Jun 18, 2020
karinazhou added a commit that referenced this pull request Mar 13, 2021
* Add event counters

* Add support netstandard 2.1 & fix the conflict in event source

* Support new event source types & add the test unit

* Remove supporting obsolete types

* fix unit test

* Add snippet sample code

* Address comments

* Fix minor typo (#3)

* Reformatting counter methods

* Fix minor typo

* Removed IsEnabled condition and reformatted counter methods

* Unit tests for Microsoft.Data.SqlClient.SqlClientEventSource (#2)

* Implemented tests for Microsoft.Data.SqlClient.SqlClientEventSource

* Updated the EventCounter test to reflect the recent changes in the code

* Working on EventCounter tests access event counters through reflection

* Updated the EventCounterTest to use reflection

* Fixing dangling SqlConnection's left in tests

* EventCountersTest now checks hard/soft connects/disconnects counters

* Reverted the DataTestUtility changes

* Reverted using statements to the old-style in tests

* Reverted the ConnectionPoolTest.ReclaimEmancipatedOnOpenTest()

* Reverted using statements to the old-style in tests

* Reverted using statements to the old-style in tests

* Rewrite the EventCounterTest assertions not to conflict with other tests

* Code review cleanup

* Add more tests (#5)

Added EventCounter_ReclaimedConnectionsCounter_Functional & EventCounter_ConnectionPoolGroupsCounter_Functional tests.

* Address comments

Co-authored-by: Davoud Eshtehari <David.esh@gmail.com>
Co-authored-by: Davoud Eshtehari <v-daesht@microsoft.com>
Co-authored-by: Karina Zhou <v-jizho2@microsoft.com>
Co-authored-by: Nikita Kobzev <win.accuracy@gmail.com>
lcheunglci referenced this pull request in lcheunglci/SqlClient May 9, 2022
* Adding TDS8 support to netcore

* Doc changes for TDS 8

Co-authored-by: JRahnama <v-jarahn@microsoft.com>
@ErikEJ ErikEJ mentioned this pull request Jun 15, 2024
benrr101 added a commit to benrr101/SqlClient that referenced this pull request Aug 29, 2024
benrr101 added a commit to benrr101/SqlClient that referenced this pull request Sep 5, 2024
benrr101 added a commit to benrr101/SqlClient that referenced this pull request Sep 11, 2024
benrr101 added a commit that referenced this pull request Sep 12, 2024
* Batch #2

* Reverting removal of the snippet files.

* Fixing build break caused by parameter not having a comment.

* These changes should fix the broken comments
benrr101 added a commit to benrr101/SqlClient that referenced this pull request Sep 16, 2024
benrr101 added a commit to benrr101/SqlClient that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants