Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix | Linux SPN port number using named instance and Kerberos authentication does not return port# #2240

Merged
merged 17 commits into from
Dec 7, 2023
Merged

Fix | Linux SPN port number using named instance and Kerberos authentication does not return port# #2240

merged 17 commits into from
Dec 7, 2023

Commits on Nov 16, 2023

  1. Push unit test to continue development in VM.

    @arellegue
    arellegue committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    e8b6a5f View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. Added unit test for SPN in managed SNI and tested in VMs in sqldrv.ad… 

    … domain.
    @arellegue
    arellegue committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    ce2481d View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2023

  1. Save to my branch all changes

    @arellegue
    arellegue committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    60f061f View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. Implemented Unit Test using Reflections.

    @arellegue
    arellegue committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    e77bfb6 View commit details
    Browse the repository at this point in the history

  2. Change TimeourTimer from 100000 to just 30 seconds.

    @arellegue
    arellegue committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    ed15e37 View commit details
    Browse the repository at this point in the history

  3. Removed and sort usings.

    @arellegue
    arellegue committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    d671acd View commit details
    Browse the repository at this point in the history

  4. Fix backwards DataTestUtility.IsNotLocalhost logic.

    @arellegue
    arellegue committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    d62c9e1 View commit details
    Browse the repository at this point in the history

  5. Removed DataTestUtility.IsManagedSNI as there is already DataTestUtil… 

    …ity.IsUsingManagedSNI.
    @arellegue
    arellegue committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    8de6014 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2023

  1. Add Type suffix to reflected types. 

    Fixed checks for localhost.
Use object initializer for array of types declarations.
    @arellegue
    arellegue committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    2d3ae85 View commit details
    Browse the repository at this point in the history

  2. Use meaningful variable names per Davoud.

    @arellegue
    arellegue committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    5907497 View commit details
    Browse the repository at this point in the history

  3. Use object type instead of var type to make code easier to understand… 

    … per Javad.
    @arellegue
    arellegue committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    589d5bd View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. Implement suggestions from PR Review.

    @arellegue
    arellegue committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    a7bd4ed View commit details
    Browse the repository at this point in the history

  2. Removed all instance of top secret domain name.

    @arellegue
    arellegue committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    94457f9 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. Moved IsManagedKerberos function from DataTestUtility class to Instan… 

    …ceNameTest class.
    @arellegue
    arellegue committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    6c6f6dc View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. Applied suggestions by Davoud "Even though this PR suggests an update… 

    … on ManagedSNI, we expect the same behavior on native SNI.".
    @arellegue
    arellegue committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    030d8f7 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. Disable unit test for Linux SPN Port# issue using ActiveIssue 27824.

    @arellegue
    arellegue committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    4a92bc7 View commit details
    Browse the repository at this point in the history

  2. Changed comment for ActiveIssue 27824.

    @arellegue
    arellegue committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    2c8e139 View commit details
    Browse the repository at this point in the history