Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Test fixes to accommodate recent infra changes #2650

Merged
merged 4 commits into from
Jul 5, 2024

Conversation

David-Engel
Copy link
Contributor

@David-Engel David-Engel commented Jul 5, 2024

These changes also include a fix for #2563 since without the changes from #2380 in the 5.2 branch, #2563 + switch to AAD auth in the pipeline results in ConnectionTimeoutInfiniteTest failing. Main still needs the fix for #2563. Ported the same fix to main: #2651

@David-Engel David-Engel marked this pull request as ready for review July 5, 2024 17:46
@DavoudEshtehari DavoudEshtehari added ✔️ Tests Identifier for test related changes 🐛 Bug! Something isn't right ! labels Jul 5, 2024
@David-Engel
Copy link
Contributor Author

@DavoudEshtehari Clean! 🎉

@David-Engel David-Engel merged commit 6907dbd into dotnet:release/5.2 Jul 5, 2024
149 checks passed
@David-Engel David-Engel deleted the pipelines52 branch July 5, 2024 23:25
@yuanhe772
Copy link

yuanhe772 commented Aug 12, 2024

"without the changes from #2380 in the 5.2 branch"

Does it mean that PR 2380 will not go in v5.2.2 release?
Kindly share if there's an ETAs for PR 2380 to be consumable, cause we're running into more transient errors of GetAccessToken() timeouts on Entra Auth as the DB load increases, thanks a lot

@DavoudEshtehari
Copy link
Member

@yuanhe772 #2380 is in the list of backports and will be included in the 5.2.2 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug! Something isn't right ! ✔️ Tests Identifier for test related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants