Merge | Interop NtDll Namespace #2983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ystemErrors, migrating usages
benrr101
added
the
Common Project 🚮
benrr101
requested review from
cheenamalhotra,
mdaigle,
samsharma2700 and
saurabh500
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2983 +/- ##
===========================================
- Coverage 92.58% 72.50% -20.08%
===========================================
Files 6 288 +282
Lines 310 59529 +59219
===========================================
+ Hits 287 43159 +42872
- Misses 23 16370 +16347
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cheenamalhotra
approved these changes
Nov 7, 2024
samsharma2700
approved these changes
Nov 7, 2024
MichelZ
pushed a commit
to MichelZ/SqlClient
that referenced
this pull request
Nov 26, 2024
* Create NtDll class, move NtCreateFile into it, migrate usages * Moving ObjectAttributes to Interop namespace, migrating usages * Move ObjectAttributeFlags to Interop namespace, migrate usage * Moving CreateDisposition to Interop namespace, migrating usages * Moving CreateOptions into Interop namespace, migrating usages * Moving DesiredAccess into Interop namespace, migrating usages * Moving SecurityQualityOfService to Interop namespace, migrating usages * Moving ImpersonationLevel into Interop namespace, migrating usages * Moving RtlNtStatusToDosError to NtDll, MID_NOT_FOUND error moved to SystemErrors, migrating usages * Moving FileFullEaInformation to Interop namespace, migrating usages * Moving IoStatusBlock to Interop namespace, migrating usages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR is the next phase of the interop namespace migration. This PR targets files that are related to the ntdll dlls. It's the same strategy as before - each commit should build by itself, they move a single file at a time. Files that has multiple classes/structs/etc in it are split into one file per class/struct/etc.
Testing: No functional changes made, just moving files around. Should be good if the build passes