Commit 648aff9
authored
[libzip, mono-runtimes, monodroid] Build with msbuild (#1539)
Like e3abe4b, but different: we had another `xbuild`-ism that
`msbuild` doesn't like: the "intermixing" of "strings" and item
metdata within *top-level* item groups.
For example:
<_MonoCrossRuntimeIntermediateOutput Include="$(IntermediateOutputPath)\%(_MonoCrossRuntime.Identity)\mono\mini\mono-sgen%(_MonoCrossRuntime.ExeSuffix)" />
The above uses item metadata, e.g. `%(_MonoCrossRuntime.Identity)`,
*outside* of a `@(_MonoCrossRuntime->'...')` context, at top-level
scope. The result is a [build break][0]
[0]: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android-msbuild/857/
src/mono-runtimes/mono-runtimes.targets(818,5): error MSB3375:
The file "obj/Debug//%(_MonoCrossRuntime.Identity)/mono/mini/mono-sgen%(_MonoCrossRuntime.ExeSuffix)" does not exist.
Note that the item metadata wasn't actually replaced, and instead was
used literally.
The fix is to replace the above "intermixing" with `@(Foo->...)`:
<_MonoCrossRuntimeIntermediateOutput Include="@(_MonoCrossRuntime->'$(IntermediateOutputPath)\%(Identity)\mono\mini\mono-sgen%(ExeSuffix)')" />
This appeases MSBuild, allowing things to build.
Review matches for:
$ git grep '<.*Include="\$.*%'
and fix any top-level `<ItemGroup/>` matches.1 parent 7418105 commit 648aff9
File tree
3 files changed
+8
-8
lines changed- src
- libzip
- mono-runtimes
- monodroid
3 files changed
+8
-8
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
| 41 | + | |
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
796 | 796 | | |
797 | 797 | | |
798 | 798 | | |
799 | | - | |
800 | | - | |
801 | | - | |
| 799 | + | |
| 800 | + | |
| 801 | + | |
802 | 802 | | |
803 | 803 | | |
804 | 804 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
105 | 105 | | |
106 | 106 | | |
107 | 107 | | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
| |||
0 commit comments