Skip to content

Commit eb7ad74

Browse files
jonpryoratsushieno
authored andcommitted
Bump to xamarin-android-api-compatibility/master/2c689ef2
Fixes: #1089 We found that xamarin-android-api-compatibility wasn't *actually* performing the inter-API-level checks, meaning an important API compatibility check wasn't being performed. Bump to xamarin-android-api-compatibility/2c689ef2 so that inter-API-level checks are properly performed. Additionally, set `$(HTML_OUTPUT_DIR)` so that `mono-api-html` output files are written into `bin/Build$(CONFIGURATION)/compatibility`. This will (hopefully) allow us to use the Jenkins **Publish HTML reports** Post-build Action to nicely display API compatibility breakage, without requiring that we read the actual build log output.
1 parent b1ce544 commit eb7ad74

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

.gitmodules

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
[submodule "external/xamarin-android-api-compatibility"]
3737
path = external/xamarin-android-api-compatibility
3838
url = https://github.com/xamarin/xamarin-android-api-compatibility.git
39-
branch = d15-7
39+
branch = master
4040
[submodule "external/xamarin-android-tools"]
4141
path = external/xamarin-android-tools
4242
url = https://github.com/xamarin/xamarin-android-tools

tests/api-compatibility/api-compatibility.mk

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,11 @@ FRAMEWORK_DIR = bin/$(CONFIGURATION)/lib/xamarin.android/xbuild-frameworks/M
1313

1414

1515
run-api-compatibility-tests: $(MONO_API_HTML) $(MONO_API_INFO)
16+
mkdir -p bin/Build$(CONFIGURATION)/compatibility
1617
make -C external/xamarin-android-api-compatibility check \
1718
MONO_API_HTML="$(RUNTIME) $(abspath $(MONO_API_HTML))" \
1819
MONO_API_INFO="$(RUNTIME) $(abspath $(MONO_API_INFO))" \
20+
HTML_OUTPUT_DIR="$(abspath bin/Build$(CONFIGURATION)/compatibility)" \
1921
XA_FRAMEWORK_DIR="$(abspath $(FRAMEWORK_DIR))"
2022

2123
$(MONO_API_HTML): $(wildcard $(MONO_API_HTML_DIR)/*.cs) $(MONO_OPTIONS_SRC)

0 commit comments

Comments
 (0)