[Java.Interop] Add JavaTypeManager class based on JavaObject #1537
Conversation
| } | ||
| } | ||
|
|
||
| public class JavaTypeManager : JavaObject |
There was a problem hiding this comment.
Can this type be internal instead of public?
There was a problem hiding this comment.
Hopefully yes. I think it should be only used from Mono.Android and the generated code, which should end up in the Mono.Android as well.
I will test whether it will indeed work in the real apk.
There was a problem hiding this comment.
It better work, or we'd implicitly be requiring that all Java.Lang.Object subclasses in all assemblies be public, which is not a pre-existing requirement. :-)
There was a problem hiding this comment.
tested and works OK here. with new marshal methods and in fallback as well.
radekdoulik
force-pushed
the
pr-java-object-based-type-manager
branch
from
393a6e5 to
c2697af
Compare
|
Out of curiosity, why inherit |
And use it from Java side in place of the old `Java.Interop.TypeManager` and its `Activate` method. As it is based on `JavaObject`, it will work nicely with the *jnimarshalmethod-gen*.
radekdoulik
force-pushed
the
pr-java-object-based-type-manager
branch
from
c2697af to
1712e21
Compare
|
Good question. Actually I don't remember :-) So I guess no particular reason. Thus I rebased it on |
|
On-device unit tests weren't executed on the macOS+xbuild PR Build run, so I restarted it to ensure we didn't break runtime tests. |
2 participants
And use it from Java side in place of the old
Java.Interop.TypeManagerand itsActivatemethod. As it is basedon
JavaObject, it will work nicely with the jnimarshalmethod-gen.