[xaprepare] Emit ThirdPartyNotices entries for mman, dlfcn #4912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`external/dlfcn-win32` and `external/mman-win32` were added in commit d8fdbcf, but we accidentally overlooked that the content of these submodules was included into built binary artifacts, and redistributed via our installers.' Consequently, these resources *should* have been listed in the generated `ThirdPartyNotices.txt` which is included in the installers, but they were not. Add appropriate `ThirdPartyNotices.txt` entries for [dlfcn-win32/dlfcn-win32][0] and [witwall/mman-win32][1]. [0]: https://github.com/dlfcn-win32/dlfcn-win32 [1]: https://github.com/witwall/mman-win32
grendello
approved these changes
Jul 13, 2020
jonpryor
added a commit
that referenced
this pull request
Jul 20, 2020
`external/dlfcn-win32` and `external/mman-win32` were added in commit d8fdbcf, but we accidentally overlooked that the content of these submodules was included into built binary artifacts, and redistributed via our installers.' Consequently, these resources *should* have been listed in the generated `ThirdPartyNotices.txt` which is included in the installers, but they were not. Add appropriate `ThirdPartyNotices.txt` entries for [dlfcn-win32/dlfcn-win32][0] and [witwall/mman-win32][1]. [0]: https://github.com/dlfcn-win32/dlfcn-win32 [1]: https://github.com/witwall/mman-win32
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
external/dlfcn-win32andexternal/mman-win32were added incommit d8fdbcf, but we accidentally overlooked that the content of
these submodules was included into built binary artifacts, and
redistributed via our installers.'
Consequently, these resources should have been listed in the
generated
ThirdPartyNotices.txtwhich is included in the installers,but they were not.
Add appropriate
ThirdPartyNotices.txtentries fordlfcn-win32/dlfcn-win32 and witwall/mman-win32.