[tests] Let BuildReleaseArm64 test apk size #5547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet#5441 Test legacy/dotnet simple/xforms Release builds apk sizes against reference apkdesc files.
Co-authored-by: Jonathan Peppers <jonathan.peppers@gmail.com>
jonpryor
reviewed
Jan 28, 2021
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/BuildTest.cs
Show resolved
Hide resolved
jonathanpeppers
approved these changes
Feb 2, 2021
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
I think this is fine for now. 👍
If we end up having several .NET global tools, we might want to use this at some point:
dotnet tool install apkdiff --tool-path ~/android-toolchain/dotnet/tools
Then we could have a local instance of all the tools our build & tests need.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #5441
Test legacy/dotnet simple/xforms Release builds apk sizes against
reference apkdesc files.